feat: update PHPStan lvl to 5#91
Conversation
7dfe886 to
9ce7944
Compare
546e5a0 to
b195deb
Compare
|
Updated based on the latest state of the develop branch. |
|
For the one remaining failure, it looks like the documentation for I think adjusting that to |
|
I won't stop you from pushing ahead here, but I feel like scope-creep is setting in 🙂 |
|
I think it was mostly editing in the web UI that made it seem bad. I've covered everything now, except the fact that |
With a type hint that doesn't include an uninitialized value as an option, it can't assume |
Yeah, I had that until #91 (comment) |
|
I'll check it some more. Especially in newer PHP versions the assumption of "unitinitialized == null" is no longer true, that's why I don't think adding a type hint for it is correct. But maybe it's the simplest solution. |
|
A simpler solution would be to bump the project to php 7.4+ or even to a supported php version. Once the native type hint is added to the instance property phpstan stops complaining. |
|
Here is the needed changes to make phpstan accept the code. |
2caeab8 to
709c6f5
Compare
This updates the PHPStan check to lvl 5. There are still some unresolved issues and the method types are based on the redis docs so might not be complete.