Fix typo for CATEGORY_NOTIFY_SLOT string#479
Open
MobCode100 wants to merge 1 commit intorenyuneyun:devfrom
Open
Fix typo for CATEGORY_NOTIFY_SLOT string#479MobCode100 wants to merge 1 commit intorenyuneyun:devfrom
MobCode100 wants to merge 1 commit intorenyuneyun:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thank you for this open source software. Actually with this PR I was intending to fix the problem of notification event that does not trigger the profile action, the problem was the
listen()andcancel()not calling its super method. But then I've made a big overlook.It was already fixed in beta branch. I think the beta release should be updated & APK should be built and put under the release assets for the
v0.8.3-beta3tag so there aren't others like me refixing the wheel.But I found a typo, so I made this PR anyways.
Edit: I've build an APK with latest commits if this concerns anyone.