bazel: switch seastar pin to rebased v26.2.x branch#30428
Draft
travisdowns wants to merge 6 commits intoredpanda-data:devfrom
Draft
bazel: switch seastar pin to rebased v26.2.x branch#30428travisdowns wants to merge 6 commits intoredpanda-data:devfrom
travisdowns wants to merge 6 commits intoredpanda-data:devfrom
Conversation
Add the new enum value to to_string.
Seastar v26.2 deprecates smp::count in favor of smp::shard_count(), exposed at top-level via this_smp_shard_count(). Unlike the static variable, the new accessor reads from the per-shard smp instance and is only valid on a reactor thread; all replaced call sites already run on reactor threads.
Update bazel/thirdparty/seastar.BUILD to match the file layout of the
seastar-rebase tree (used by --config=localssr). Without these
additions the seastar library cannot compile.
New feature areas:
+ src/core/crypto.{cc,hh}, src/core/crypto_openssl.cc
f860454a7 "crypto: introduce crypto provider abstraction"
+ include/seastar/core/internal/md5.hh
cfdf47740 "net/tcp: use crypto provider for md5 calculation"
+ src/websocket/client.cc, include/seastar/websocket/client.hh
fe77940e6 "websocket: impl client side websocket function"
+ include/seastar/util/integrated-length.hh
d0ccb7d4b "util: Introduce gauge integrator helper"
Header-extraction refactors:
+ include/seastar/util/memory-data-sink.hh
801b1566f "util: Generalize memory_data_sink"
Renames:
- src/net/ossl.cc -> src/net/tls_openssl.cc (+ tls_openssl.hh)
952a19ec3 "net/tls: add openssl tls backend"
Seastar v26.2 deprecates smp::all_cpus() in favor of smp::all_shards(), exposed at top-level via this_smp_all_shards(). Unlike the static, the new accessor reads from the per-shard smp instance and is only valid on a reactor thread; both replaced call sites already run on reactor threads. Same pattern as b6d168bad8.
Seastar v26.2 deprecates reply::done() and reply::done(content_type). The bare done() cached _response_line, which write_reply() never read, so it was always dead. The done(content_type) overload is equivalent to set_content_type(content_type). Replace each call site accordingly: drop bare done() and use set_content_type() where a content type was being passed. Also valid against the prior pinned seastar SHA, where _response_line is similarly write-only.
Point at the rebased v26.2.x branch (redpanda-data/seastar#277). Replaces the prior v26.2.x-pre snapshot at a0b4f2a6.
Member
Author
|
/dt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the RP-side change to swap over to the rebased seastar branch
(still in review upstream — see
redpanda-data/seastar#277).
The final commit (
bazel: update seastar to 097536ff) is the actual pinflip; the rest are local source-side adjustments needed to keep the
tree compiling on top of the rebased seastar. Several closely related
fixups already landed on
devseparately and are not included here:1966ded1d8 seastar: drop SEASTAR_DEPRECATED_OSTREAM_FORMATTERS definetest_utils/container_ostream.h36e53c39d1 admin: convert uuid_t to sstring for json_return_type7fa117202e net/connection: declare TLS reconnect error codes locally(net/connection: declare TLS reconnect error codes locally #30391)
628c6060e2 bazel/seastar: bump API level to 9Commits on this branch:
ss-rebase-26.2: add hugetlbfs to to_string— small enum additionthe rebased seastar surfaces in the redpanda tree.
treewide: replace deprecated ss::smp::count— mechanical migrationto
ss::this_smp_shard_count();ss::smp::countis deprecated inthe rebase.
bazel/seastar: sync source list with v26.2.x-rebase— refreshesbazel/thirdparty/seastar.BUILDsrcs/hdrs lists to match the rebasedtree (added/removed files, the
SEASTAR_HAVE_OPENSSL/ OpenSSLprovider wiring, etc.).
raft/rpc: replace deprecated ss::smp::all_cpus— analogue of (2)for
smp::all_cpus→this_smp_all_shards().treewide: replace deprecated http::reply::done()— drops theno-op
done()calls and replacesdone(content_type)withset_content_type(). Also open standalone as treewide: replace deprecated http::reply::done() #30395; if thatmerges first I'll drop it from this branch.
bazel: update seastar to 097536ff— the pin flip itself, pointingat the rebased seastar branch (PR #277).
Backports Required
Release Notes