Remove ADP availability admonition for GA descope#378
Merged
micheleRP merged 1 commit intofeature/badge-byoc-onlyfrom May 6, 2026
Merged
Remove ADP availability admonition for GA descope#378micheleRP merged 1 commit intofeature/badge-byoc-onlyfrom
micheleRP merged 1 commit intofeature/badge-byoc-onlyfrom
Conversation
ADP Cloud is descoped from the 2026-06-15 GA. With BYOC as the only deployment shape, the "Available in: Cloud, BYOC" / "Available in: BYOC" admonition no longer informs the reader and adds visual noise on every ADP page. Drop the entire `page.attributes.adp` availability block from src/partials/article.hbs. Other badges (beta, limited-availability, context-switcher, BYOC/Cloud labels for non-ADP pages) keep working unchanged. Companion PR: redpanda-data/adp-docs#13 ships the same change locally via Antora's supplemental_files mechanism so the deploy preview is fixed immediately. Once a new docs-ui release tag is cut from this branch and the adp-docs / docs-site playbooks are bumped to it, the supplemental override in adp-docs becomes redundant and can be deleted. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops the
page.attributes.adpavailability block fromsrc/partials/article.hbs. ADP Cloud is descoped from the 2026-06-15 GA, so BYOC is the only deployment shape and the "Available in: Cloud, BYOC" / "Available in: BYOC" admonition that the bundle injects on every ADP page no longer informs the reader.The block was added in 37bacc1 ("Add availability block and enhance ADP page styling") and refined in 5b36bdd ("Address CodeRabbit review comments"). This PR removes it entirely now that the descope decision has landed.
Other badges keep working unchanged:
beta,limited-availability,context-switcher, and the BYOC / Cloud nav-metadata labels for non-ADP pages (lines 32-43 are untouched, still gated on{{#unless page.attributes.adp}}).Companion PR
redpanda-data/adp-docs#13 ships the same change locally as an Antora
supplemental_filesoverride so the deploy preview build is fixed immediately, ahead of a docs-ui release. Once this PR merges, a new release tag is cut fromfeature/badge-byoc-only, and theadp-docs/docs-siteplaybooks are bumped to the new release, thesupplemental-ui/override in adp-docs becomes redundant and can be deleted (cleanup PR will follow).Test plan
gulp lintpasses cleanly (CSS + JS).adp-docsbuild with the new bundle no longer renders any<div class="availability-block">on ADP pages.🤖 Generated with Claude Code