Migration - Base UI based registry components#2424
Migration - Base UI based registry components#2424
Conversation
SpicyPete
requested review from
a team,
jvorcak and
weeco
and removed request for
a team
| <Field data-invalid={fieldState.invalid}> | ||
| <FieldLabel required>Scopes</FieldLabel> | ||
| <MultiSelect | ||
| items={SCOPE_OPTIONS} |
There was a problem hiding this comment.
How do item options get shared with multi select?
There was a problem hiding this comment.
{SCOPE_OPTIONS.map((option) => (
Just below this in the file we are mapping over SCOPE_OPTIONS again, so before we were passing them in twice, but only 1 was being used.
|
@malinskibeniamin I think this is ready for a review this week. Fixed a bunch of registry components over the last week, and brought the latest versions all into here now. |
| }, | ||
| "iconLibrary": "lucide" | ||
| "iconLibrary": "lucide", | ||
| "registries": { |
There was a problem hiding this comment.
I think AI elements deserve a separate look because they were originally pulled in from the https://elements.ai-sdk.dev/components/context for example
| Text, | ||
| } from '@redpanda-data/ui'; | ||
| import { TrashIcon } from 'components/icons'; | ||
| import { DateTimeInput } from 'components/ui/date-time-input'; |
| "@tanstack/react-form": "^1.12.3", | ||
| "@tanstack/react-query": "^5.90.7", | ||
| "@tanstack/react-router": "^1.158.0", | ||
| "@tanstack/react-router": "^1.168.10", |
2 participants
Summary
Notes:
user-preferencesdialog with registry components to help surface some registry bugsdate-time-inputcomponent + shim the date-fns-tz so the Chakra components can still compile.Todo