Skip to content

fix(setnx): use set with nx instead setnx #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndyakov merged 2 commits into from
Mar 11, 2026
+1 −4
Merged

fix(setnx): use set with nx instead setnx #3723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
744ff20
fix(setnx): use set with nx instead setnx
ndyakov Feb 26, 2026
317a056
Merge branch 'master' into ndyakov/remove-deprecation-setnx
ndyakov Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions string_commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,17 +429,14 @@ func (c cmdable) SetEx(ctx context.Context, key string, value interface{}, expir

// SetNX sets the value of a key only if the key does not exist.
//
// Deprecated: Use Set with NX option instead as of Redis 2.6.12.
//
// Zero expiration means the key has no expiration time.
// KeepTTL is a Redis KEEPTTL option to keep existing TTL, it requires your redis-server version >= 6.0,
// otherwise you will receive an error: (error) ERR syntax error.
func (c cmdable) SetNX(ctx context.Context, key string, value interface{}, expiration time.Duration) *BoolCmd {
var cmd *BoolCmd
switch expiration {
case 0:
// Use old `SETNX` to support old Redis versions.
cmd = NewBoolCmd(ctx, "setnx", key, value)
cmd = NewBoolCmd(ctx, "set", key, value, "nx")
case KeepTTL:
cmd = NewBoolCmd(ctx, "set", key, value, "keepttl", "nx")
default:
Expand Down
Loading