Skip to content

fix: defer validation for unresolved conditional branches#701

Open
Stefanqn wants to merge 4 commits intoreagento:developfrom
Stefanqn:feature/static_eval
Open

fix: defer validation for unresolved conditional branches#701
Stefanqn wants to merge 4 commits intoreagento:developfrom
Stefanqn:feature/static_eval

Conversation

@Stefanqn
Copy link
Copy Markdown

No description provided.

@Tishka17
Copy link
Copy Markdown
Member

Actually, I would check as much as possible at graph building stage. Probably, we should have a toggle to enable this behavior

@Stefanqn Stefanqn force-pushed the feature/static_eval branch from c9e3f73 to 481ce05 Compare March 30, 2026 12:24
@Stefanqn
Copy link
Copy Markdown
Author

both is fine for me

@Tishka17
Copy link
Copy Markdown
Member

Looks like we have 2 options here:

  1. validate disabled
  2. validate dynamically calculated

@Stefanqn
Copy link
Copy Markdown
Author

like that?

@Stefanqn Stefanqn force-pushed the feature/static_eval branch from 6e4f4d9 to 8b5b95c Compare March 30, 2026 22:28
@Stefanqn
Copy link
Copy Markdown
Author

Stefanqn commented Mar 31, 2026

I also added a toggle per factory in my latest commit

Should alias(...) and from_context(...) support the same override as well?

@Tishka17
Copy link
Copy Markdown
Member

Isn't per factory setting too much? Do we have any UseCase for that?

@Stefanqn
Copy link
Copy Markdown
Author

if it's too much, drop the last commit :)
I think it's kinda useful if you'd like to keep strict / fail-fast behavior and want to explicitly mark or patch a certain case.

@Stefanqn
Copy link
Copy Markdown
Author

Stefanqn commented Apr 1, 2026

Can I accelerate merging any kind of bugfix for when=Has()? I'm really looking forward to use this feature

@Tishka17
Copy link
Copy Markdown
Member

Tishka17 commented Apr 2, 2026

Do you have any particular usecase for this specific PR? I am not sure if I am satisfied with the API changes here though it has some sense here. Do you need this together with #696 at this moment?

@Tishka17
Copy link
Copy Markdown
Member

Tishka17 commented Apr 2, 2026

In terms of configuring validation is see these cases:

  1. Factory is overridden
  2. Factory is just disabled
  3. Factory is disabled by static evaluation
  4. Factory can be dynamically disabled
  5. Factory is enable by static evaluation
  6. Factory is always enabled

For me it is not clear how should we let user decide whether to skip checks. In #696 I went with simple logic: cases 1,2,3 disable validation, others are always validated.

@Tishka17 Tishka17 deleted the branch reagento:develop April 3, 2026 13:02
@Tishka17 Tishka17 closed this Apr 3, 2026
@github-project-automation github-project-automation bot moved this to To be released in Dishka kanban Apr 3, 2026
@Tishka17 Tishka17 reopened this Apr 3, 2026
@Tishka17 Tishka17 changed the base branch from feature/static_eval to develop April 3, 2026 13:03
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 3, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To be released

Development

Successfully merging this pull request may close these issues.

2 participants