Skip to content

Refactor/public interface#81

Open
Niccolum wants to merge 27 commits intomainfrom
refactor/public_interface
Open

Refactor/public interface#81
Niccolum wants to merge 27 commits intomainfrom
refactor/public_interface

Conversation

@Niccolum
Copy link
Copy Markdown
Collaborator

@Niccolum Niccolum commented Mar 31, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA d01d22b.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Coverage: 93% (no change)

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 12 additional findings in Devin Review.

Open in Devin Review

) -> LoaderProtocol:
if loaders is not None:
return loaders[index]
return resolve_loader(source_meta, expand_env_vars=expand_env_vars, type_loaders=type_loaders)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Pre-existing: nested_resolve_strategy not applied in multi-source function mode

In multi-source function mode, merge_load_as_function calls _load_and_merge without loaders, so load_sources creates loaders via resolve_loader_for_source at src/dature/loading/source_loading.py:33 which does NOT pass nested_resolve_strategy or nested_resolve to resolve_loader. This means load(s1, s2, schema=Config, nested_resolve_strategy="json") won't apply the strategy unless each Source sets it explicitly. In contrast, decorator mode uses _MergePatchContext._prepare_loaders at src/dature/loading/multi.py:469-498 which correctly passes these params. This is a pre-existing issue — the old Merge-based code had the same discrepancy. The PR preserves the behavior without fixing it.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant