Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
|
Coverage: 93% (no change) |
| ) -> LoaderProtocol: | ||
| if loaders is not None: | ||
| return loaders[index] | ||
| return resolve_loader(source_meta, expand_env_vars=expand_env_vars, type_loaders=type_loaders) |
There was a problem hiding this comment.
🚩 Pre-existing: nested_resolve_strategy not applied in multi-source function mode
In multi-source function mode, merge_load_as_function calls _load_and_merge without loaders, so load_sources creates loaders via resolve_loader_for_source at src/dature/loading/source_loading.py:33 which does NOT pass nested_resolve_strategy or nested_resolve to resolve_loader. This means load(s1, s2, schema=Config, nested_resolve_strategy="json") won't apply the strategy unless each Source sets it explicitly. In contrast, decorator mode uses _MergePatchContext._prepare_loaders at src/dature/loading/multi.py:469-498 which correctly passes these params. This is a pre-existing issue — the old Merge-based code had the same discrepancy. The PR preserves the behavior without fixing it.
Was this helpful? React with 👍 or 👎 to provide feedback.
Uh oh!
There was an error while loading. Please reload this page.