Skip to content

test: cover mini-decimal scientific notation fix #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombieJ merged 3 commits into from
Mar 13, 2026
+12 −16
Merged

test: cover mini-decimal scientific notation fix #730

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
220ddc3
test: cover mini-decimal scientific notation fix
zombieJ Mar 13, 2026
673f532
test: assert scientific notation display value
zombieJ Mar 13, 2026
57b7f64
test: rename jest config back to ts
zombieJ Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
setupFiles: ['./tests/setup.js'],
};
16 changes: 0 additions & 16 deletions jest.config.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
]
},
"dependencies": {
"@rc-component/mini-decimal": "^1.0.1",
"@rc-component/mini-decimal": "^1.1.1",
"@rc-component/util": "^1.4.0",
"clsx": "^2.1.1"
},
Expand Down
4 changes: 4 additions & 0 deletions tests/decimal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ describe('InputNumber.Decimal', () => {
expect(container.querySelector('input').value).toEqual('0.1');
});

it('should not crash when scientific notation precision exceeds native toFixed limit', () => {
expect(() => render(<InputNumber defaultValue={1e-307} />)).not.toThrow();
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current test correctly verifies that rendering does not crash. However, it could be strengthened by also asserting that a value is actually rendered in the input. This would prevent future regressions where the component might fail silently (e.g., by rendering an empty string) instead of crashing. The suggested change implicitly keeps the crash check, as render would throw an exception and fail the test if it crashed.

    const { container } = render(<InputNumber defaultValue={1e-307} />);
    expect(container.querySelector('input').value).not.toBe('');

});

it('custom decimal separator', () => {
const onChange = jest.fn();
const { container } = render(<InputNumber decimalSeparator="," onChange={onChange} />);
Expand Down
Loading