Skip to content

feat: add -movable classname #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ug-hero wants to merge 2 commits into
base: master
Choose a base branch
from
+22 −1
Open

feat: add -movable classname #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42df24b
update
Mar 13, 2026
427d62f
Merge branch 'master' into feat/addClass
Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Preview/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,7 @@ const Preview: React.FC<PreviewProps> = props => {
return (
<div
className={clsx(prefixCls, rootClassName, classNames.root, motionClassName, {
[`${prefixCls}-movable`]: movable,
[`${prefixCls}-moving`]: isMoving,
})}
style={mergedStyle}
Expand Down
22 changes: 21 additions & 1 deletion tests/preview.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import RotateLeftOutlined from '@ant-design/icons/RotateLeftOutlined';
import RotateRightOutlined from '@ant-design/icons/RotateRightOutlined';
import ZoomInOutlined from '@ant-design/icons/ZoomInOutlined';
import ZoomOutOutlined from '@ant-design/icons/ZoomOutOutlined';
import Dialog from '@rc-component/dialog';
import { spyElementPrototypes } from '@rc-component/util/lib/test/domHook';
import { act, createEvent, fireEvent, render } from '@testing-library/react';
import React from 'react';
import Dialog from '@rc-component/dialog';

jest.mock('../src/Preview', () => {
const MockPreview = (props: any) => {
Expand Down Expand Up @@ -383,6 +383,26 @@ describe('Preview', () => {
});
});

it('should render movable className correctly according to movable prop', () => {
const { rerender } = render(
<Image
src="https://zos.alipayobjects.com/rmsportal/jkjgkEfvpUPVyRjUImniVslZfWPnJuuZ.png"
preview={{ open: true }}
/>,
);

expect(document.querySelector('.rc-image-preview')).toHaveClass('rc-image-preview-movable');

rerender(
<Image
src="https://zos.alipayobjects.com/rmsportal/jkjgkEfvpUPVyRjUImniVslZfWPnJuuZ.png"
preview={{ open: true, movable: false }}
/>,
);

expect(document.querySelector('.rc-image-preview')).not.toHaveClass('rc-image-preview-movable');
});

it('Mouse Event', () => {
const clientWidthMock = jest
.spyOn(document.documentElement, 'clientWidth', 'get')
Expand Down