Skip to content

fix: prevent page scroll when switching images with keyboard #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cactuser-Lu wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: prevent page scroll when switching images with keyboard #493

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
deb3bfe
fix: prevent page scroll when switching images with keyboard
Dec 30, 2025
adf7f18
update keycode
Dec 30, 2025
6273ace
add isEditable
Jan 13, 2026
77acb0e
update
Jan 13, 2026
9dc2a9d
update testcase
Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"dependencies": {
"@rc-component/motion": "^1.0.0",
"@rc-component/portal": "^2.1.2",
"@rc-component/util": "^1.3.0",
"@rc-component/util": "^1.7.0",
"clsx": "^2.1.1"
},
"devDependencies": {
Expand Down
9 changes: 4 additions & 5 deletions src/Preview/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import CSSMotion from '@rc-component/motion';
import Portal, { type PortalProps } from '@rc-component/portal';
import { useEvent } from '@rc-component/util';
import useLayoutEffect from '@rc-component/util/lib/hooks/useLayoutEffect';
import KeyCode from '@rc-component/util/lib/KeyCode';
import { clsx } from 'clsx';
import React, { useContext, useEffect, useRef, useState } from 'react';
import { PreviewGroupContext } from '../context';
Expand Down Expand Up @@ -330,13 +329,13 @@ const Preview: React.FC<PreviewProps> = props => {
// >>>>> Effect: Keyboard
const onKeyDown = useEvent((event: KeyboardEvent) => {
if (open) {
const { keyCode } = event;

if (showLeftOrRightSwitches) {
if (keyCode === KeyCode.LEFT) {
if (event.key === 'ArrowLeft') {
onActive(-1);
} else if (keyCode === KeyCode.RIGHT) {
event.preventDefault();
} else if (event.key === 'ArrowRight') {
onActive(1);
event.preventDefault();
}
}
}
Expand Down
Loading