Skip to content

feat: preferences settings revamp#1483

Open
rohanchkrabrty wants to merge 1 commit intofeat-general-revampfrom
feat-profilw-revamp
Open

feat: preferences settings revamp#1483
rohanchkrabrty wants to merge 1 commit intofeat-general-revampfrom
feat-profilw-revamp

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

  • Added GeneralView and PreferencesView components to the SDK with full profile settings UI
  • Introduced reusable SDK primitives: ViewContainer, ViewHeader, ImageUpload, and DeleteOrganizationDialog
  • Upgraded SDK to use Apsara v1 and updated client-demo app to showcase the new settings pages

@rohanchkrabrty rohanchkrabrty self-assigned this Mar 27, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Mar 27, 2026 8:05am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 27, 2026

Caution

Review failed

Failed to post review comments

📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • New Features

    • Added image upload functionality for organization avatars with cropping support.
    • Added organization settings pages for managing General settings and user Preferences.
    • Added theme selector (Light/Dark/System) to user preferences.
    • Added newsletter subscription toggle in Preferences.
    • Added organization deletion capability with title confirmation.
  • Chores

    • Updated React to v19.

Walkthrough

The PR upgrades React to version 19, adds a new settings management flow with nested routes for organization general and preference configuration, introduces reusable UI components (ImageUpload, ViewContainer, ViewHeader), updates SDK dependencies and exports, and adds corresponding view implementations and styling.

Changes

Cohort / File(s) Summary
React 19 Upgrade
web/apps/client-demo/package.json, web/sdk/package.json
Updated React and React-DOM from v18 to v19; updated TypeScript type definitions; shifted from @stitches/react to @base-ui/react for styling foundation; added @raystack/apsara-v1 as new dependency.
Settings Routes & Navigation
web/apps/client-demo/src/Router.tsx, web/apps/client-demo/src/pages/Home.tsx, web/apps/client-demo/src/styles.css, web/apps/client-demo/src/App.tsx
Added nested route structure under /:orgId/settings with child routes for general and preferences; updated Home page to link to new settings UI; added CSS reset for body margins/padding; imported new stylesheet dependencies.
Settings Layout & Pages
web/apps/client-demo/src/pages/Settings.tsx, web/apps/client-demo/src/pages/settings/General.tsx, web/apps/client-demo/src/pages/settings/Preferences.tsx
Introduced Settings parent component managing organization context and navigation sidebar; added General settings page with delete callback integration; added Preferences page rendering PreferencesView.
Reusable UI Components
web/sdk/react/components/image-upload/*, web/sdk/react/components/view-container/*, web/sdk/react/components/view-header/*
Created ImageUpload component with file selection, canvas-based crop dialog, and JPEG export; created ViewContainer wrapper with configurable content layout; created ViewHeader with title/description display and right-aligned slot.
Settings Views & Dialogs
web/sdk/react/views-new/general/*, web/sdk/react/views-new/preferences/*
Implemented GeneralView with form-based organization title/name/avatar editing, mutation handling, and delete dialog integration; implemented PreferencesView with theme selection and newsletter subscription controls; created DeleteOrganizationDialog with confirmation and protobuf-based deletion mutation; created PreferenceRow component for preference item layout.
Styling & CSS Modules
web/sdk/react/components/.../\\*.module.css, web/sdk/react/views-new/.../\\*.module.css
Added CSS modules for image upload layout/behavior, view container spacing, delete confirmation button, general view sections, and preference row separators.
SDK Configuration & Exports
web/sdk/react/index.ts, web/sdk/package.json, web/sdk/tsup.config.ts, web/sdk/admin/components/SheetFooter.tsx
Extended React SDK exports to include new components and views; removed css prop from SheetFooter and updated border styling to design-system variable; added react-dom to external build dependencies.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

  • refactor: remove all instances of react-router-dom #1410 — Conflicts with main PR's routing approach: adds react-router-dom Link/Navigate/Outlet patterns while that PR removes router dependencies and replaces with callback-based navigation.
  • feat: move sdk billing #1425 — Directly related: both PRs expose GeneralView, PreferencesView, and DeleteOrganizationDialog components in SDK exports and introduce the same settings view implementations.
  • feat: move sdk general #1414 — Related: both PRs modify GeneralView and delete-organization-dialog implementations, sharing responsibility for the organization settings deletion UI and callbacks.

Suggested reviewers

  • rsbh
  • rohilsurana
  • paanSinghCoder
✨ Finishing Touches
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch feat-profilw-revamp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty changed the base branch from main to feat-general-revamp March 27, 2026 08:06
@rohanchkrabrty rohanchkrabrty added the Do not merge Label to indicate that the PR is not ready to be merged even though might be (or not) approvals. label Mar 27, 2026
@rohanchkrabrty rohanchkrabrty changed the title feat: profile settings revamp feat: preferences settings revamp Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do not merge Label to indicate that the PR is not ready to be merged even though might be (or not) approvals.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant