Skip to content

fix: conditionally display media details - [CU-869bgh5j7] #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abdallah-farag27 wants to merge 1 commit into
base: dev
Choose a base branch
from
+7 −1
Open

fix: conditionally display media details - [CU-869bgh5j7] #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/pages/media/[id].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ function handleReplied(tweet: Tweet) {
</Carousel>
</div>

<div class="ms-auto min-h-screen w-100 overflow-y-auto">
<div class="ms-auto hidden min-h-screen w-100 overflow-y-auto lg:block">
<div v-if="tweetData">
<TweetView :tweet="tweetData" :media="false" />
</div>
Expand Down
6 changes: 6 additions & 0 deletions test/nuxt/layouts/home.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,15 @@ import { describe, it, expect, vi, beforeEach } from 'vitest';
import { mountSuspended } from '@nuxt/test-utils/runtime';
import { createI18n } from 'vue-i18n';
import messages from '@@/i18n/locales/en.json';
import { ref } from 'vue';

const i18n = createI18n({ locale: 'en', messages: { en: messages } });

vi.stubGlobal('$route', { path: '/home' });
vi.stubGlobal('useAccountSetup', () => ({
start: vi.fn(),
isOpen: ref(false),
}));

describe('Home layout', () => {
beforeEach(() => {
Expand All @@ -22,6 +27,7 @@ describe('Home layout', () => {
Tabs: { template: '<div><slot /></div>' },
Tab: { name: 'Tab', template: '<div />' },
TweetComposer: { template: '<div class="tweet-composer-stub" />' },
AccountSetup: true,
},
plugins: [i18n],
},
Expand Down
Loading