feat: allow reconcilers to override their configuration at runtime#1090
feat: allow reconcilers to override their configuration at runtime#1090
Conversation
If a reconciler implements `ConfigurableReconciler`, then QOSDK will derive a new configuration for the reconciler by calling `updateConfigurationFrom` before registering the reconciler with this new configuration.
xstefank
left a comment
There was a problem hiding this comment.
I think this is better. But wasn't there also a test?
There isn't at the moment, but I need to add some, indeed. |
|
Yes, yep! Will work just fine! |
|
Thanks. Closing this PR as this will instead be supported in extensions instead of JOSDK core. |
|
I'm a little bit puzzled on why this was closed. Isn't this the extension repo where this should be living? Or maybe I'm understanding it wrongly? What is the relation of operator-framework/java-operator-sdk#2784 to this PR? Thanks and sorry! |
|
I'm puzzled as well! 😅 |
That PR is a change I thought would be needed but isn't after all. This is a tangential issue that is also kind of orthogonal (if that makes any sense!) 😁 |
If a reconciler implements
ConfigurableReconciler, then QOSDK willderive a new configuration for the reconciler by calling
updateConfigurationFrombefore registering the reconciler with thisnew configuration.