Fix flaky timing assertion in gloo transport multiproc tests#505
Open
yahayaohinoyi wants to merge 1 commit into
Open
Fix flaky timing assertion in gloo transport multiproc tests#505yahayaohinoyi wants to merge 1 commit into
yahayaohinoyi wants to merge 1 commit into
Conversation
Summary: The IoErrors and UnboundIoErrors tests assert that error propagation after SIGKILL completes within `kMultiProcTimeout * 2` (6s). On loaded CI machines, TCP error detection and process scheduling delays can push wall-clock time well beyond this limit (observed ~10.6s), causing spurious failures. Relax the multiplier from 2x to 4x to accommodate CI variability while still catching genuine hangs. ___ overriding_review_checks_triggers_an_audit_and_retroactive_review Oncall Short Name: testing_frameworks Differential Revision: D102326105
|
@yahayaohinoyi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102326105. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The IoErrors and UnboundIoErrors tests assert that error propagation after SIGKILL completes within
kMultiProcTimeout * 2(6s). On loaded CI machines, TCP error detection and process scheduling delays can push wall-clock time well beyond this limit (observed ~10.6s), causing spurious failures. Relax the multiplier from 2x to 4x to accommodate CI variability while still catching genuine hangs.overriding_review_checks_triggers_an_audit_and_retroactive_review
Oncall Short Name: testing_frameworks
Differential Revision: D102326105