Skip to content

fix: pass auth via Request constructor instead of calling HTTPBasicAuth on unprepared Request #10748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Affanmir wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −3
Open

fix: pass auth via Request constructor instead of calling HTTPBasicAuth on unprepared Request #10748

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a47d6f2
fix: pass auth via Request constructor instead of calling HTTPBasicAu…
Affanmir Feb 24, 2026
ce94c32
Merge branch 'main' into fix/authenticator-basic-auth-request-prepara…
Affanmir Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/poetry/utils/authenticator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,13 +189,15 @@ def request(
self, method: str, url: str, raise_for_status: bool = True, **kwargs: Any
) -> requests.Response:
headers = kwargs.get("headers")
request = requests.Request(method, url, headers=headers)
credential = self.get_credentials_for_url(url)

auth = None
if credential.username is not None or credential.password is not None:
request = requests.auth.HTTPBasicAuth(
auth = requests.auth.HTTPBasicAuth(
credential.username or "", credential.password or ""
)(request)
)

request = requests.Request(method, url, headers=headers, auth=auth)

session = self.get_session(url=url)
prepared_request = session.prepare_request(request)
Expand Down