Skip to content

fix: support removing packages from project.optional-dependencies #10734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
by22Jy wants to merge 2 commits into
base: main
Choose a base branch
from
+32 −0
Open

fix: support removing packages from project.optional-dependencies #10734

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
876f304
fix: support removing packages from project.optional-dependencies
by22Jy Feb 13, 2026
5eab690
refactor: handle optional-dependencies separately instead of using st…
by22Jy Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions src/poetry/console/commands/remove.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,24 @@ def handle(self) -> int:
if group_name not in groups_content and group_name != MAIN_GROUP
)

# Also include project.optional-dependencies (PEP 621)
optional_deps = project_content.get("optional-dependencies", {})
for optional_group, optional_list in optional_deps.items():
if optional_list:
group_sections.append(
(f"optional:{optional_group}", optional_list, {})
)

for group_name, standard_section, poetry_section in group_sections:
is_optional = group_name.startswith("optional:")
removed |= self._remove_packages(
packages=packages,
standard_section=standard_section,
poetry_section=poetry_section,
group_name=group_name,
skip_group_update=is_optional,
)
if group_name != MAIN_GROUP:
if group_name != MAIN_GROUP and not is_optional:
if (
not poetry_section
and "dependencies" in poetry_groups_content.get(group_name, {})
Expand All @@ -114,9 +124,18 @@ def handle(self) -> int:
if (
group_name not in groups_content
and group_name not in poetry_groups_content
and not group_name.startswith("optional:")
):
self._remove_references_to_group(group_name, content)

# Clean up empty optional-dependencies entries
optional_deps = project_content.get("optional-dependencies", {})
for optional_group in list(optional_deps.keys()):
if not optional_deps[optional_group]:
del optional_deps[optional_group]
if not optional_deps:
project_content.pop("optional-dependencies", None)

elif group == "dev" and "dev-dependencies" in poetry_content:
# We need to account for the old `dev-dependencies` section
removed = self._remove_packages(
Expand Down Expand Up @@ -190,9 +209,11 @@ def _remove_packages(
standard_section: list[str | Mapping[str, Any]],
poetry_section: dict[str, Any],
group_name: str,
skip_group_update: bool = False,
) -> set[str]:
removed = set()
group = self.poetry.package.dependency_group(group_name)
if not skip_group_update:
group = self.poetry.package.dependency_group(group_name)

for package in packages:
normalized_name = canonicalize_name(package)
Expand All @@ -207,8 +228,9 @@ def _remove_packages(
del poetry_section[existing_package]
removed.add(package)

for package in removed:
group.remove_dependency(package)
if not skip_group_update:
for package in removed:
group.remove_dependency(package)

return removed

Expand Down