Drop explicit build and virtualenv installation from Pyodide build tools#2782
Merged
agriyakhetarpal merged 1 commit intopypa:mainfrom Mar 16, 2026
Conversation
Member
Not sure if we want to vendor the whole |
ryanking13
approved these changes
Mar 16, 2026
Member
Author
This is indeed what I was working on in the past hour; sounds good to me! |
joerick
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See
0911b78(#2775) and #2775 (comment): it is better that we removebuild[virtualenv]from the top-level install command entirely.pyodide-buildalready declaresbuild~=1.2.0andvirtualenvas direct dependencies, so they'll come in transitively at the right versions.cibuildwheelshouldn't be separately requestingbuild[virtualenv]for the Pyodide platform.Perhaps, at some later point, we should vendor
buildintopyodide-buildand drop the pins. I briefly recall some conversations about this with @ryanking13 (not sure where that was?).