Skip to content

Drop explicit build and virtualenv installation from Pyodide build tools#2782

Merged
agriyakhetarpal merged 1 commit intopypa:mainfrom
agriyakhetarpal:drop-build's-installation-from-pyodide-build-tools
Mar 16, 2026
Merged

Drop explicit build and virtualenv installation from Pyodide build tools#2782
agriyakhetarpal merged 1 commit intopypa:mainfrom
agriyakhetarpal:drop-build's-installation-from-pyodide-build-tools

Conversation

@agriyakhetarpal
Copy link
Member

@agriyakhetarpal agriyakhetarpal commented Mar 16, 2026

See 0911b78 (#2775) and #2775 (comment): it is better that we remove build[virtualenv] from the top-level install command entirely. pyodide-build already declares build~=1.2.0 and virtualenv as direct dependencies, so they'll come in transitively at the right versions. cibuildwheel shouldn't be separately requesting build[virtualenv] for the Pyodide platform.

Perhaps, at some later point, we should vendor build into pyodide-build and drop the pins. I briefly recall some conversations about this with @ryanking13 (not sure where that was?).

@ryanking13
Copy link
Member

Perhaps, at some later point, we should vendor build into pyodide-build and drop the pins. I briefly recall some conversations about this with @ryanking13 (not sure where that was?).

Not sure if we want to vendor the whole build package to pyodide-build, but I think we can relax the pin to make it more flexible. We've removed all usage of the private methods, so I think it is quite stabler than before when we first started using it.

@agriyakhetarpal
Copy link
Member Author

I think we can relax the pin to make it more flexible. We've removed all usage of the private methods, so I think it is quite stabler than before when we first started using it.

This is indeed what I was working on in the past hour; sounds good to me!

@agriyakhetarpal agriyakhetarpal merged commit a94d4fa into pypa:main Mar 16, 2026
43 checks passed
@agriyakhetarpal agriyakhetarpal deleted the drop-build's-installation-from-pyodide-build-tools branch March 16, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants