(Repaired) Detect local arguments functions used in a function#214
Closed
(Repaired) Detect local arguments functions used in a function#214
Conversation
In #164. I'm leveraging the diff comparison between main and the last commit in that PR that I didn't touch: https://github.com/pyiron/flowrep/compare/1e893dede850a43f2e0d3cc5595f3cb62fda1da9..e334f1f8815fc52e70d472e485dab9a024216437. Weirdly, most of the files identified as "moved" from flowrep/models to src/flowrep, but the two relevant files (`(test_)dependency_parser.py`) showed as completely removed and completely re-written. This caused me to completely delete @samwaseda's actual work in that branch during the merge. Here I lose the git history, but recover the actual file changes there. Plus I ran black and updated the module paths to reflect the current location of file in main. (actually same is primary author) Co-authored-by: Sam Dareska <37879103+samwaseda@users.noreply.github.com> Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
===========================================
- Coverage 100.00% 98.42% -1.58%
===========================================
Files 30 30
Lines 2009 2035 +26
===========================================
- Hits 2009 2003 -6
- Misses 0 32 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
hmm the imports are still not there... It's ok don't worry. I'll take care of it in #164 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairing my busted merge in #164.
I'm leveraging the diff comparison between main and the last commit in that PR that I didn't touch: https://github.com/pyiron/flowrep/compare/1e893dede850a43f2e0d3cc5595f3cb62fda1da9..e334f1f8815fc52e70d472e485dab9a024216437. Weirdly, most of the files identified as "moved" from flowrep/models to src/flowrep, but the two relevant files (
(test_)dependency_parser.py) showed as completely removed and completely re-written. This caused me to completely delete @samwaseda's actual work in that branch during the merge.Here I lose the git history, but recover the actual file changes there. Plus I ran black and updated the module paths to reflect the current location of file in main.
@samwaseda, can you take a peek to see if this looks correct?