-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add missing Vercel AI SDK v6 tool approval part types #4388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DouweM
merged 25 commits into
pydantic:main
from
bendrucker:fix-ai-sdk-v6-approval-types
Mar 6, 2026
Merged
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
bb68274
Add missing AI SDK v6 tool approval part types
bendrucker 7deea88
fix: sort imports in _utils.py
bendrucker 9253470
Simplify tool approval tests
bendrucker e0fe7c7
Fix iter_tool_approval_responses matching output-denied parts
bendrucker 02090a2
Preserve tool denial state through message round-trips
bendrucker 7de6dac
Update test_hitl_tool_approval snapshot for is_denied field
bendrucker 5c878fd
Store denial state in metadata instead of a dedicated field
bendrucker d56705e
Update test_approval_required_toolset snapshot for metadata and run_id
bendrucker e579ab4
Preserve denial reason through dump/load round-trips
bendrucker 1337144
ci: re-trigger CI
bendrucker 6b3de96
Add test for denied builtin tool return streaming
bendrucker 9a01bd8
Replace is_denied property with status field on BaseToolReturnPart
bendrucker 4a76f2e
Fix serialized snapshot and doc example field ordering for status
bendrucker ab201a0
Set status='error' on BuiltinToolReturnPart for tool errors in Vercel…
bendrucker da65341
Fix rebase conflicts: adopt _safe_args_as_dict/tool_return_output, up…
bendrucker 0530744
Use ToolOutput*Part (not DynamicToolOutput*Part) for non-builtin tool…
bendrucker 50b33ba
Use status field for error detection in builtin tool dump path
bendrucker c475fd8
Merge branch 'main' into fix-ai-sdk-v6-approval-types
DouweM caaa672
review feedback
dmmihov 993dbc9
Apply suggestions from code review
bendrucker 7e13e2f
Address review feedback: use ToolReturnPart(outcome='error') for tool…
bendrucker b2836f6
Lazy-import `_web` in `pydantic_ai.ui` to avoid starlette dependency …
bendrucker ff9e574
Add test for builtin tool return error event stream coverage
bendrucker a7e5423
Rename outcome 'error' to 'failed', use ToolDenied().message for deni…
bendrucker 700cce6
Update tests/test_vercel_ai.py
bendrucker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DouweM marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.