Skip to content

fix: annotate always-detected packages in logfire run suggestions #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nightcityblade wants to merge 3 commits into from
Closed

fix: annotate always-detected packages in logfire run suggestions #1736

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b41cc37
fix: annotate stdlib and OTel dependency packages in logfire run sugg…
Feb 25, 2026
0489af5
Merge branch 'main' into fix/issue-1296
alexmojaki Feb 27, 2026
c652b8d
Merge branch 'main' into fix/issue-1296
alexmojaki Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion logfire/_internal/cli/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
import logfire

STANDARD_LIBRARY_PACKAGES = {'urllib', 'sqlite3'}
# Packages that are always present because they're dependencies of OpenTelemetry itself
OTEL_DEPENDENCY_PACKAGES = {'requests'}

# Map of instrumentation packages to the packages they instrument
OTEL_INSTRUMENTATION_MAP = {
Expand Down Expand Up @@ -235,9 +237,21 @@ def instrumented_packages_text(
def get_recommendation_texts(recommendations: set[tuple[str, str]]) -> tuple[Text, Text]:
"""Return (recommended_packages_text, install_all_text) as Text objects."""
sorted_recommendations = sorted(recommendations)
has_auto_packages = False
recommended_text = Text()
auto_packages = STANDARD_LIBRARY_PACKAGES | OTEL_DEPENDENCY_PACKAGES
for pkg_name, instrumented_pkg in sorted_recommendations:
recommended_text.append(f'☐ {instrumented_pkg} (need to install {pkg_name})\n', style='grey50')
if instrumented_pkg in auto_packages:
has_auto_packages = True
recommended_text.append(f'☐ {instrumented_pkg}* (need to install {pkg_name})\n', style='grey50')
else:
recommended_text.append(f'☐ {instrumented_pkg} (need to install {pkg_name})\n', style='grey50')
if has_auto_packages:
recommended_text.append('\n')
recommended_text.append(
'* Always detected (stdlib or OpenTelemetry dependency) — ignore if not used in your code.\n',
style='dim italic',
)
recommended_text.append('\n')

install_text = Text()
Expand Down
Loading