Add on_change callbacks for managed variables#1699
Open
Conversation
Add comprehensive tests covering uncovered lines across the variables module: is_resolve_function edge cases, variant deserialization errors, remote provider change detection, force refresh, variant diffing, variable type operations, push_variable_types, and more. Add pragmas for genuinely untestable code paths (fork handler, unreachable fallback).
Covers: resolve function default without type, duplicate variable name, on_config_change with unknown variable, and multiple keyword-only params.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Add a `timeout` field to `RemoteVariablesConfig` (default `(10, 10)`) so that both the polling thread and the blocking first-resolve path use a bounded `Session.get` call. Also propagate `timeout_millis` through `VariableProvider.shutdown()` so thread joins respect the shutdown budget.
…sion optional - Remove `enabled` field from VariableConfig (disabled variables are now modeled by pointing labels to code_default) - Add `code_default` handling in `follow_ref` - returns (None, None) to trigger code default fallthrough - Make `LabelRef.version` optional (None for code_default and label-to-label refs) - Update `_validate_labels` to skip code_default refs in label validation - Update tests to use code_default pattern instead of enabled=False
- Remove `enabled` field from VariableConfig reference table - Document `code_default` as a LabelRef target - Note that LabelRef.version is optional - Add explanations for when to use each ref target type
Extract on_change callback functionality into a separate PR to keep the managed-variables branch focused on the core feature.
Add support for registering callbacks that fire when a variable's configuration changes, enabling reactive patterns like cache invalidation and feature flag updates.
Deploying logfire-docs with
|
| Latest commit: |
cd4d77d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://45d68fc6.logfire-docs.pages.dev |
| Branch Preview URL: | https://managed-variables-on-change.logfire-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened as a separate PR to iterate on the API for this a bit. @alexmojaki had some objections on the design in the other PR #1691
Summary
Variable.on_change()method to register callbacks that fire when a variable's remote configuration changesVariableProvider.set_on_config_change()/_notify_config_change()for provider-level change detectionLogfireRemoteVariableProvider.refresh()compares old/new configs and notifies on differencesLocalVariableProvidernotifies oncreate_variable,update_variable, anddelete_variableLogfire.var()and handles re-wiring onlogfire.configure()reconfigurationTest plan
on_changecallback firing on variable updates, creates, and deletes