Skip to content

feat(openai): Add gen_ai.response.id for Chat Completions and Responses API #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jimilp7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(openai): Add gen_ai.response.id for Chat Completions and Responses API #1644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions logfire/_internal/integrations/llm_providers/openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,9 @@ def get_endpoint_config(options: FinalRequestOptions) -> EndpointConfig:
if is_current_agent_span('Responses API', 'Responses API with {gen_ai.request.model!r}'):
return EndpointConfig(message_template='', span_data={})

stream = json_data.get('stream', False)
span_data = {
'gen_ai.request.model': json_data.get('model'),
'request_data': {'model': json_data.get('model'), 'stream': stream},
'request_data': json_data,
'events': inputs_to_events(
json_data.get('input'),
json_data.get('instructions'),
Expand Down Expand Up @@ -296,6 +295,8 @@ def on_response(response: ResponseT, span: LogfireSpan) -> ResponseT:
span.set_attribute('gen_ai.usage.output_tokens', output_tokens)

if isinstance(response, ChatCompletion) and response.choices:
if response.id:
span.set_attribute('gen_ai.response.id', response.id)
span.set_attribute(
'response_data',
{'message': response.choices[0].message, 'usage': usage},
Expand All @@ -311,6 +312,9 @@ def on_response(response: ResponseT, span: LogfireSpan) -> ResponseT:
elif isinstance(response, ImagesResponse):
span.set_attribute('response_data', {'images': response.data})
elif isinstance(response, Response): # pragma: no branch
if response.id:
span.set_attribute('gen_ai.response.id', response.id)

try:
events = json.loads(span.attributes['events']) # type: ignore
except Exception:
Expand Down
Loading