Support overriding default model provider in instrument_openai

logfire/_internal/integrations/llm_providers/llm_provider.py

@@ -26,6 +26,7 @@ def instrument_llm_provider(
     get_endpoint_config_fn: Callable[[Any], EndpointConfig],
     on_response_fn: Callable[[Any, LogfireSpan], Any],
     is_async_client_fn: Callable[[type[Any]], bool],
+    provider: str | None = None,
 ) -> AbstractContextManager[None]:
     """Instruments the provided `client` (or clients) with `logfire`.
 
@@ -93,6 +94,8 @@ def _instrumentation_setup(*args: Any, **kwargs: Any) -> Any:
                 return None, None, kwargs
 
             span_data['async'] = is_async
+            if provider is not None:
+                span_data['gen_ai.system'] = provider
 
             if kwargs.get('stream') and stream_state_cls:
                 stream_cls = kwargs['stream_cls']

logfire/_internal/integrations/llm_providers/openai.py

@@ -183,7 +183,8 @@ def on_response(response: ResponseT, span: LogfireSpan) -> ResponseT:
         on_response(response.parse(), span)  # type: ignore
         return cast('ResponseT', response)
 
-    span.set_attribute('gen_ai.system', 'openai')
+    if getattr(span, 'attributes', None) is None or (span.attributes or {}).get('gen_ai.system', None) is None:
+        span.set_attribute('gen_ai.system', "openai")
 
     if isinstance(response_model := getattr(response, 'model', None), str):
         span.set_attribute('gen_ai.response.model', response_model)

logfire/_internal/main.py

@@ -1171,6 +1171,7 @@ def instrument_openai(
         | None = None,
         *,
         suppress_other_instrumentation: bool = True,
+        provider: str = "openai",
     ) -> AbstractContextManager[None]:
         """Instrument an OpenAI client so that spans are automatically created for each request.
 
@@ -1237,6 +1238,7 @@ def instrument_openai(
             get_endpoint_config,
             on_response,
             is_async_client,
+            provider,
         )
 
     def instrument_openai_agents(self) -> None: