Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Cargo.toml
Outdated
| tracing = "0.1" | ||
| tracing-subscriber = { version = "0.3", features = ["env-filter"] } | ||
| tracing-opentelemetry = "0.31" | ||
| tracing-opentelemetry = { git = "https://github.com/marc-pydantic/tracing-opentelemetry", branch = "marc/opentelemetry-0.31" } |
There was a problem hiding this comment.
Would it be easier if you move this in as a module to this crate?
There was a problem hiding this comment.
I'd say equally different. I assume this is a stopgap measure for now.
|
This may not work with the greater ecosystem as well, which sucks. There are some other crates we are using that depend on |
|
Can we just update to |
Not straight away, as the underlying API has changed significantly in the meantime, for reasons I don't understand yet. After spending a few fruitless hours trying to replicate the old The breaking change occurred here: tokio-rs/tracing-opentelemetry#202 -- you'll see that others have also felt the changes. There's already some work in undoing some of the damage (tokio-rs/tracing-opentelemetry#234), it might be that eventually a more backwards-compatible version of |
(currently opening this to get a CI run)
The underlying
opentelemetryshould at some point migrate from0.30to0.31, if only to because some transitive dependencies have moved on, e.g.prost.The
tracing-opentelemetrycrate had some unforced changes going from0.30to0.31(opentelemetryversion, NOTtracing-opentelemetry, which confusingly is a one minor version ahead).This branch is using a fork of
tracing-opentelemetrythat has manually seen itsopentelemetryupdated.