Revert "Adopt to latest puppetlabs/apt changes"

[joshcooper]

This reverts commit 84850a5.

The latest puppet_agent module is not compatible with the most recently released puppetlabs-apt module, so reverting just this one commit from PR #740.

We will need to first release puppetlabs-apt and then re-revert this.

[joshcooper]

@bastelfreak We ran into compatibility issues when testing the latest puppet_agent module with the last released puppetlabs-apt module

Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, apt::setting needs either of content or source

And need to revert this while we wait for the apt module to be released. puppetlabs/puppetlabs-apt#1209 Once that happens, I think we can re-revert this change and update the metadata to require apt >= 10.0.

That said I'm not sure why these unit tests are failing, e.g. https://github.com/puppetlabs/puppetlabs-puppet_agent/actions/runs/12207528812/job/34059134139?pr=744#step:6:502 Wondering if there were multiple commits that need to be reverted?

[bastelfreak]

@joshcooper how urgent is this? Can't we get the apt release out?

[bastelfreak]

Modules team said they will release the module on Wednesday.

[amitkarsale]

@joshcooper , If there is a blocker we can release puppetlabs-apt module earlier. There is a request to consider few PR's in the release hence waiting.

[joshcooper]

how urgent is this? Can't we get the apt release out?

@bastelfreak as long as puppet_agent bumps its major version and updates its dependency on apt (to a version that allows content to be omitted when using ensure => absent), then I'm ok closing this PR.

[bastelfreak]

@joshcooper can you do another round of testing and release the puppet_agent module? the puppetlabs/apt release is there now.

[joshcooper]

@bastelfreak I verified puppet_agent tests pass with latest apt module #747, so closing this. We'll still need to verify the module with PE and then we can release the module.