Open
Conversation
smortex
force-pushed
the
jps-help/main
branch
from
3186d23 to
ccdc12e
Compare
3 tasks
smortex
force-pushed
the
jps-help/main
branch
from
ccdc12e to
9821579
Compare
Collaborator
Author
|
Rebased on top of the main branch. I guess that the invalid parameter markup make this become a bugfix PR rather that a maintenance one now that the code was released. |
|
Could this be merged and released ? :) |
|
I tested this on our fleet. Looks good and fixes an issues we had with whitespaces after a few fields leading to endless re-applies. You got a moment to take a look @bastelfreak ? |
smortex
changed the title
Collaborator
Author
|
Rebased on top of |
bwitt
approved these changes
Jan 10, 2026
BuJo
approved these changes
Jan 22, 2026
BuJo
left a comment
BuJo
left a comment
There was a problem hiding this comment.
The failing test is just on one platform, and it merely failed to pull some artifacts from a puppetlabs host. Should be fine to merge @bastelfreak ?
Test the generated content as a whole instead of part of line by part of line, add add missing parameters to improve coverage.
skyamgarp
force-pushed
the
jps-help/main
branch
from
77ccec6 to
1d1f94f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is based on #1167 and tidy a bit the template and tests.Improve and fix DEB822-style template. Improve test coverage.
Related Issues (if any)
Add support for deb822 APT sources #1167