Add support for checking if an apt::keyring is up-to-date with checksums#1199
Add support for checking if an apt::keyring is up-to-date with checksums#1199NeatNerdPrime wants to merge 3 commits intopuppetlabs:mainfrom
apt::keyring is up-to-date with checksums#1199Conversation
NeatNerdPrime
requested review from
a team,
bastelfreak and
smortex
as code owners
|
|
smortex
changed the title
apt::keyring is up-to-date with checksums
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
That looks good but we also need to adjust the apt::source defined type so that we can pass the checksum / checksum_value there too through the key parameter.
In response to @smortex comment: puppetlabs#1199 (review) * Trickled up the checksum-related parameters for `apt::source` * Modified test for source, all green.
|
Hello again. I added the requested changes, but whiel doing so i stumbled upon a perhaps uncomfortable situation. Given the changes in the source_spec.rb test: https://github.com/puppetlabs/puppetlabs-apt/pull/1199/files#diff-abe1d0bffeeb2d6d33970b8d3272b76455f72cf2541de5f85678bd76817446e4 I realize that the parameter 'key' in It begs the question: "Should we add a parameter 'keyring' to the defined resource, being mutually exclusive to the 'key' parameter, that calls upon This could make things more clear from a user perspective and - unless Im mistaken - should be backwards compatible. What do you people think? |
NeatNerdPrime
force-pushed
the
issues/1196
branch
from
6fdaca8 to
12b7f80
Compare
In response to @smortex comment: puppetlabs#1199 (review) * Trickled up the checksum-related parameters for `apt::source` * Modified test for source, all green.
|
@NeatNerdPrime , could you please update the PR? |
Add checksum and checksum_value parameters to apt::keyring defined type, enabling integrity verification of keyring files from remote HTTP sources that do not provide the necessary headers for the file resource to detect content changes. Supported checksum types: md5, sha256, sha224, sha384, sha512. Ref: puppetlabs#1196
Trickle up the checksum-related parameters from apt::keyring to apt::source, allowing users to specify checksum and checksum_value in the key hash when declaring an apt::source resource. Update documentation examples, key param description, REFERENCE.md, and source spec tests to cover the new parameters. Ref: puppetlabs#1196
- Remove blank line before `define apt::auth` that caused puppet-strings to miss the @summary tag, resulting in an undocumented defined type. - Shorten apt_key @summary to under 140 characters and move the detail into the description body. - Align parameter default `=` signs across all manifests for consistent readability: auth, backports, conf, init, key, pin, ppa, setting, and source. - Regenerate REFERENCE.md. Documentation coverage is now 100%.
NeatNerdPrime
force-pushed
the
issues/1196
branch
from
12b7f80 to
0aa3d36
Compare
|
@skyamgarp done, please check |
5 participants
#1196
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)