Skip to content

Support PPA in deb822 format#1169

Merged
malikparvez merged 3 commits intopuppetlabs:mainfrom
fredericgiquel:ppa-deb822
Dec 18, 2024
Merged

Support PPA in deb822 format#1169
malikparvez merged 3 commits intopuppetlabs:mainfrom
fredericgiquel:ppa-deb822

Conversation

@fredericgiquel
Copy link
Copy Markdown

Summary

Since Ubuntu 23.10, add-apt-repository no longer creates a .list file but a .sources file (in deb822 format).

Additional Context

Related Issues (if any)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@fredericgiquel fredericgiquel requested review from a team, bastelfreak and smortex as code owners March 12, 2024 09:09
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 12, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related: #1167.

Comment thread manifests/ppa.pp Outdated
@grant-veepshosting
Copy link
Copy Markdown

grant-veepshosting commented Oct 16, 2024

There seems to be an extra leading $ character on L59 in manifests/ppa.pp main branch.

Comment thread manifests/ppa.pp Outdated
@grant-veepshosting
Copy link
Copy Markdown

@smortex is there a chance you could look at merging this PR (and the related one)?

@amitkarsale
Copy link
Copy Markdown

Is this PR good the be merged, all checks are passing?

fredericgiquel and others added 3 commits November 27, 2024 11:58
Co-authored-by: Kenyon Ralph <kenyon@kenyonralph.com>
Co-authored-by: Kenyon Ralph <kenyon@kenyonralph.com>
Copy link
Copy Markdown
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, though would be best to run the tests against an Ubuntu 24.04 machine first to confirm.

@malikparvez malikparvez merged commit 30e8065 into puppetlabs:main Dec 18, 2024
amateo pushed a commit to amateo/puppetlabs-apt that referenced this pull request Dec 4, 2025
amateo added a commit to amateo/puppetlabs-apt that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants