Surface warnings when editing with the CLI#631
Merged
Conversation
Add severity field to EnvironmentDiagnostic to distinguish warnings from errors. When editing environments, warnings are now displayed to stderr while still allowing the update to succeed. Fixes #626
Two fixes: 1. Parse the update response body to get warnings (previously only errors from HTTP 400 responses were shown) 2. Use project/env format for diagnostic filenames to match API response, fixing "source code not available" display issue
seanyeh
approved these changes
Apr 7, 2026
| } | ||
|
|
||
| func (d EnvironmentDiagnostic) IsError() bool { | ||
| return d.Severity != DiagWarning |
Contributor
There was a problem hiding this comment.
i would check if severity == error
Member
Author
There was a problem hiding this comment.
I added the == error check but we also need == "" for backward compat.
| "github.com/pulumi/esc" | ||
| ) | ||
|
|
||
| type EnvironmentDiagnosticSeverity string |
Contributor
There was a problem hiding this comment.
is there a reason we use string instead of hcl.DiagnosticSeverity? (I'm fine with either)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Severityfield toEnvironmentDiagnosticto distinguish warnings from errorsTest plan
env-edit-file-warnings.yamltest caseFixes #626