Document property columns in Resource Explorer#18630
Document property columns in Resource Explorer#18630AnuiDolphin wants to merge 5 commits intomasterfrom
Conversation
Add a Property columns section to the Resource Search docs covering creation from the gear menu, adding from the detail view, sort/filter/group behavior, column chooser visibility, and URL-based view sharing. Reuse the Team/Enterprise/Business Critical tier callout already used for property queries, and add a matching bullet to the Discovery key capabilities list. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Docs reviewSolid, well-structured addition. The new section mirrors the existing Property queries pattern (tier-gating callout, property-path link), uses sentence-case headings, and sticks to A few small things worth considering: 1. Oxford-comma inconsistency between the two files
The search.md wording intentionally matches the existing Property queries callout at line 277 (which also omits the Oxford comma), so this PR is internally consistent with its neighbor — but the two new additions disagree with each other. Google's Developer Documentation Style Guide prefers the serial comma. Low-stakes suggestion: align both on the Oxford-comma form. For (You may also want to update the existing Property queries callout on line 277 to match, though that's arguably out of scope for this PR.) 2. Long bullet in
|
|
Your site preview for commit c21b445 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18630-c21b445e.s3-website.us-west-2.amazonaws.com |
- Use "settings icon" instead of "gear icon" for the menu control - Rewrite the detail-view section: drill in via the name cell, and document the single Create property column action whose behavior depends on whether the value is a singleton or an object with children - Replace "hiding and showing" with "hiding and deleting": hiding is done via Choose columns in the settings menu; deletion is done by dragging a property column out of the grid, and only works for property columns (not built-in columns) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Add Oxford comma to the Property columns tier callout in search.md for consistency with the bullet in _index.md - Drop 'first-class column' phrasing; the next sentence already explains the behavior - Rewrite the sharing-views paragraph in active voice - Tighten the Key capabilities bullet to match the brevity of its neighbors by dropping the inline examples (still covered in full in search.md) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Thanks for the detailed pass, @claude. Addressed in fbdc82f:
|
|
Claude finished @AnuiDolphin's task in 41s —— View job Second-pass review
All five items from the first review are confirmed addressed in the current branch:
The additional author-driven corrections (gear → settings icon, detail-view entry via name cell, single Create property column action with singleton-vs-object branching, Hiding and deleting property columns split into two distinct behaviors) all look correct and accurate based on the description provided. This is clean and ready to merge. |
Replace three em-dashes in the new property-columns content with periods / a semicolon so the voice matches the rest of search.md, which has no em-dashes elsewhere. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CamSoper
left a comment
There was a problem hiding this comment.
Looks good, Craig. One small voice tweak pushed: smoothed three em-dashes in the property-columns section since they were the only ones in the file. Also refreshed the PR body so the UI labels match the final wording ("Create property column" / "Choose columns" / settings menu).
Worth one last pass against the preview once pulumi/pulumi-service#40053 ships, particularly the deletion flow (drag column out of grid) and the URL-persistence claim. Otherwise ready to merge whenever.
Co-authored-by: Craig Symonds <craig@anui.com>
Summary
content/docs/insights/discovery/search.mddocumenting the new dynamic property columns feature in Insights Resource Explorer (pulumi/pulumi-service#40053).content/docs/insights/discovery/_index.md.The new section covers:
No screenshots are added -- the written descriptions are detailed enough to stand on their own and avoid the drift risk that comes with UI screenshots.
Test plan
🤖 Generated with Claude Code