Update all colors and remove old brand elements#18619
Update all colors and remove old brand elements#18619jeffmerrick wants to merge 14 commits intomasterfrom
Conversation
|
Your site preview for commit 9ebfd9e is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18619-9ebfd9ec.s3-website.us-west-2.amazonaws.com |
Lighthouse Performance ReportCommit: 9ebfd9e | Metric definitions
|
|
Docs Review posted by CI. Testing posting capability. |
|
Docs review part 1/3: Likely bugs. (1) layouts/page/brand.html line 8 still renders pulumi-tertiary-nav with items bound to .Params.sections, but content/brand/_index.md no longer defines sections — jsonify on nil emits null, so the element will get items=null and may throw JS errors. Guard with {{ with .Params.sections }}...{{ end }} or remove the nav block. (2) content/brand/_index.md meta_desc still says 'Official brand logos and colors for use with Pulumi.' but the page body is now just 'Update coming soon.' — update the description or add noindex until rebuilt. (3) layouts/page/pricing.html line 71 was partially updated: border-violet-600 became border-violet-primary, but sibling text-violet-600 was missed. In the new palette violet-600 is 915df9 and violet-primary is 702eea, so text ends up lighter than its border. |
|
Docs review part 2/3: Documentation debt and dead references. (4) BUILD-AND-DEPLOY.md line 3742 references theme/tailwind.config.js which is deleted in this PR. Per AGENTS.md, build/infra changes should update BUILD-AND-DEPLOY.md — worth a note that the site now uses Tailwind v4 CSS-first @theme config in theme/src/scss/_theme.scss. (5) The deleted tailwind.config.js contained a cache-bust-2025-12 color added to bust the CloudFront CSS cache (referencing issue 16274). If the cache-bust mechanism is still needed, it should live somewhere in the new pipeline; if not, a note explaining why would help future maintainers. (6) PR description lists roughly 8 templates with .rainbow-text, 20 with .shape-background, 5 with .dot-overlay/.dot-background; a grep across layouts/ turns up 27 files referencing at least one. Not a blocker, but a follow-up cleanup issue would be good. (7) Remaining salmon/fuchsia/purple refs beyond the three noted in the PR: layouts/page/about.html:138 (text-salmon-600), layouts/page/about.html:146 (text-fuchsia-600), layouts/page/microsoft-for-startups.html:44 (bg-salmon-200), layouts/page/pulumi-for-startups.html:44 (bg-salmon-200), layouts/partials/events/speakers-template.html:21 (/images/avatars/avatar-purple.png still in a shuffle of avatar choices). |
|
Docs review part 3/3: Style/hygiene and clean findings. (8) Missing trailing newline in theme/src/scss/_hero.scss — confirmed in the diff. (9) 'border-top: 4px solid; border-color: 702eea;' pattern in layouts/page/reinvent.html (lines 188, 209, 234, 255) and layouts/partner/aws.html (lines 230, 258) works because sibling borders default to width 0, but 'border-top: 4px solid 702eea;' is clearer and avoids setting color on three invisible sides. Clean findings: content markdown changes (icon_color: purple to violet) are consistent with the new icon palette. Three touched blog posts (aws-lambda-container-support, azure-container-apps, get-up-and-running-with-azure-synapse-and-pulumi) are class-name swaps only, no content changes, so the 'do not update blog posts' rule does not apply. No old brand hex codes (805ac3, 8a3391, bd4c85) remain in layouts/ or theme/; remaining hits in static/logos/ look like vendor/package logos. Mention @ claude (remove the space) if you want me to take another pass once these are addressed. |
|
Summary: the 3 comments above are the docs review for this PR. Three likely bugs (brand page nav bound to removed .Params.sections, stale meta_desc on brand page, pricing.html text-violet-600 missed in find/replace), two documentation-debt items (BUILD-AND-DEPLOY.md still references deleted tailwind.config.js; cache-bust token from issue 16274 needs tracking), broader dead-class residue than the PR description notes, a missing trailing newline in _hero.scss, and a minor border-shorthand style nit. Markdown content and blog class-swaps look clean. (Ignore the 'Docs Review posted by CI' placeholder above — it was a posting-capability test I could not delete.) |
|
@vctrfrnndz On point as usual! Wrong color was swapped in there, should be fixed now. |
|
I expanded the scope and applied fonts and did general style and layout updates throughout, including /docs. Now I've changed 261 files 😬 so it's a bit massive but everything should look much better! |
Docs review — PR #18619 (color system refresh)Scoped to Markdown/content changes. Layout/SCSS/asset changes were scanned for related issues but not reviewed line-by-line — the PR description handles the intentional no-ops transparently. Issues1. The YAML examples (lines 47, 70) now use
Either keep both as Also worth a quick product-branding gut-check: is the mascot now officially described as violet? If the mascot itself stays "purple" colloquially, you may want to revert the YAML example values on lines 47 and 70 rather than change the prose. 2. Missed The PR description notes that
Suggest updating each to Notes (non-blocking)
If you'd like another pass after fixes, mention me (@claude) in a comment. |
CamSoper
left a comment
There was a problem hiding this comment.
Nice cleanup. The new typography looks great on the docs pages — really happy with how it's landing.
Verified:
- No dangling
purple/fuchsia/salmonclasses incontent/orlayouts/. - All
color:values in frontmatter resolve to existing--color-*tokens. tailwind.config.js/tokens.jsongone;_theme.scsspalette in place.- Tailwind v4
@sourceguidance in BUILD-AND-DEPLOY.md matchesmain.scss.
Given the breadth (260 files), I didn't visually inspect every page — recommend eyeballing the preview on at least /about/, /gads/neo/, /topics/kubernetes/, and one of the blog callouts before merging.
Heads-up: /brand/ is now a "coming soon" stub — external deep links to brand assets will land there until the follow-up ships.

Proposed changes
Update all colors and remove old brand elements
This is a rather massive PR but sometimes you just need to bite the bullet with a somewhat reckless find and replace. This should bring colors closer to being in alignment with the new brand while removing older brand elements like the dot patterns, gradient and circles. In general the focus was just on swapping in new colors so page layouts will still need to be revisited for new design work.
Completes replacement of the legacy Sass-based color system (
_colors.scss,tailwind.config.js,tokens.json) with the CSS-custom-property-based brand palette defined in_theme.scssusing Tailwind v4's CSS-first@theme {}config.Key changes:
--color-*custom properties--color-violet-primary(#702eea), etc.$brand-blue,map-get($gray, 600), etc.) replaced withvar(--color-*)throughout SCSS and Stencil web component stylesFor later:
Updates to docs button styles and colorsFont updates (#18536)Updates to /guides (separate repo)
Update blog images
Update
Decided to go all out and updating fonts and docs styles as well.
@font-facedeclarations for Gilroy, Iosevka, and Roboto Mono from_fonts.scss.btncolor updated fromblue-600toviolet-primary;.btn-secondaryredesigned with neutral border treatment; translucent button variants migrated from Sassrgba()to CSScolor-mix()--color-violet-950); removed separate_chroma-min-dark.scssoverride fileResolves: #18535
Resolves: #18538
Resolves: #18536