-
Notifications
You must be signed in to change notification settings - Fork 56
Searching messages in a room (not encrypted) #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 19 commits
31ccf5b
8009d1e
0cff367
4506ddb
1620a30
81a842a
52d7efa
6b3fc4b
a772bc2
9c4b11e
6d2d63e
ea6cb60
ef2ddb5
5321861
c76173e
c0e0931
497973a
af68741
02b09db
ca2ca78
fbfb272
747cb44
dfa349b
3357364
687cdf1
2c160eb
9a48f94
2d6f5f9
c86643a
769c517
6d2c06e
1a010bf
75aec63
51d5869
8314625
50d3a5a
b0e97af
5b8f99a
9290fd8
8cb2ff0
31ca5dc
6adad73
20db1bd
2025fb1
fb9b75d
bccb820
62d6612
69bc0c4
874e95f
64ab172
a830265
151f123
19e00fb
efb995e
4f81dd8
203fefa
d738c2d
98c8715
d4766d6
c69e9ba
609c73c
557b0f0
faaf403
ffd41d8
568096f
aee984c
2d71975
4003e5c
6fe116f
e3de362
59d7169
3c9d936
bf71ffd
c5eb255
ce12f4f
db2f1af
bdd4383
da4c301
499c370
8144a44
32b0463
e541b3e
4833fcd
fbb72dc
c2417e4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2,9 +2,8 @@ use makepad_widgets::*; | |||||
| use matrix_sdk::ruma::OwnedRoomId; | ||||||
| use std::collections::HashMap; | ||||||
|
|
||||||
| use crate::{app::{AppState, AppStateAction, SelectedRoom}, utils::room_name_or_id}; | ||||||
| use crate::{app::{AppState, AppStateAction, SelectedRoom}, shared::room_filter_input_bar::RoomFilterAction, utils::room_name_or_id}; | ||||||
| use super::{invite_screen::InviteScreenWidgetRefExt, room_screen::RoomScreenWidgetRefExt, rooms_list::RoomsListAction}; | ||||||
|
|
||||||
| live_design! { | ||||||
| use link::theme::*; | ||||||
| use link::shaders::*; | ||||||
|
|
@@ -210,6 +209,7 @@ impl MainDesktopUI { | |||||
| dock.close_tab(cx, tab_id); | ||||||
| self.tab_to_close = None; | ||||||
| self.open_rooms.remove(&tab_id); | ||||||
| cx.widget_action(self.widget_uid(), &Scope::empty().path, RoomFilterAction::Clear); | ||||||
|
||||||
| cx.widget_action(self.widget_uid(), &Scope::empty().path, RoomFilterAction::Clear); | |
| cx.widget_action(self.widget_uid(), &scope.path, RoomFilterAction::Clear); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be there is better to use action() if we dont want an actual Scope rather than widget_action()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't be necessary, as you can access ruma types via
matrix_sdk::ruma::The problem with doing this is that we now have an added maintenance burden because we have to ensure that this version perfectly matches that of the matrix SDK and its UI crate.
Does
matrix_sdk::rumanot already publicly re-export the types/functions that you need?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed