fix: add proto build flag to allow option proto fields#698
Merged
kate-goldenring merged 2 commits intoproject-akri:mainfrom Jul 29, 2024
Merged
fix: add proto build flag to allow option proto fields#698kate-goldenring merged 2 commits intoproject-akri:mainfrom
kate-goldenring merged 2 commits intoproject-akri:mainfrom
Conversation
kate-goldenring
requested review from
Britel,
adithyaj,
bfjelds,
diconico07,
jiria,
johnsonshih and
romoh
as code owners
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
kate-goldenring
force-pushed
the
fix-proto-build
branch
from
5ca67ac to
3f02e7b
Compare
Contributor
Author
|
/version patch |
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
Author
|
@adithyaj @diconico07 this should be ready to review |
diconico07
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently builds fail due to using deprecated use of optional fields. This adds in a build flag to ignore the error. We should remove the proto
optionalspecifier and update the crateref #696