fix(queues): avoid ':' in BullMQ job ids (fixes #32)#33
Merged
productdevbook merged 1 commit intoproductdevbook:mainfrom Apr 22, 2026
Merged
Conversation
BullMQ throws `Custom Id cannot contain :` when a custom jobId contains
a colon (':' is a reserved Redis key separator). The notification queue
was using colons in both `fanout:<id>` and the device/channel job ids
built by `getSendNotificationJobId`, which caused `sendNotification` to
always fail with FAILED status. Channel 'to' values (e.g. Web Push
endpoint URLs like `https://fcm.googleapis.com/...`) also leaked colons
into the id.
Replace colons with hyphens in all custom job ids and sanitize the
channel 'to' segment. Closes productdevbook#32.
Contributor
Author
|
any updates? |
Owner
|
Please excuse the delay. I’ve been busy publishing several npm package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #32 —
sendNotificationalways fails withCustom Id cannot contain :.BullMQ rejects custom
jobIds containing:(it's the reserved Redis key separator). The notification queue was building ids with colons:For channel/Web Push jobs, `to` is also an endpoint URL (`https://fcm.googleapis.com/...\`) — so colons leak in from there too.
Fix
Test plan
Determinism (same id for same `(notificationId, deviceId)` / `(notificationId, channelId, to)` pair) is preserved, so BullMQ's dedup behavior is unchanged.