📦 Use forked class-validator package#696
Merged
douglasduteil merged 2 commits intomainfrom Nov 14, 2025
Merged
Conversation
rdubigny
force-pushed
the
use-forked-class-validator
branch
4 times, most recently
from
c458704 to
661e419
Compare
**Problem** They are inheritance issues in `class-validator` (see issue: typestack/class-validator#633). We updated a PR to fix this problem: typestack/class-validator#2641. However, the chances of it ever being merged are low, as the repository no longer appears to be actively maintained. **Proposal** Use the patched package and import it via an "ugly" github link. This should push us toward eventually migrating to another validation library such as Zod.
rdubigny
force-pushed
the
use-forked-class-validator
branch
from
661e419 to
5151c10
Compare
**Problem** Since `class-validator` inheritance was broken, we duplicated several field declarations in the identity DTOs and `UserSession` ended up being mistyped in some controllers. **Proposal** Use DTO inheritance to avoid this issues.
rdubigny
requested review from
BenoitSerrano,
douglasduteil,
gdarquie and
rebeccadumazert
| "body-parser": "^2.2.0", | ||
| "class-transformer": "^0.5.1", | ||
| "class-validator": "^0.14.2", | ||
| "class-validator": "proconnect-gouv/class-validator#build-0.14.2-proconnect.1", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
They are inheritance issues in
class-validator(see issue:typestack/class-validator#633).
We updated a PR to fix this problem:
typestack/class-validator#2641.
However, the chances of it ever being merged are low, as the repository
no longer appears to be actively maintained.
Proposal
Use the patched package and import it via an "ugly" github link.
This should push us toward eventually migrating to another validation
library such as Zod.