Skip to content

OpenFOAM 10: Fixes adapter not reading coupling data#335

Open
simrnjandu wants to merge 1 commit intoprecice:OpenFOAM10from
simrnjandu:OpenFOAM10
Open

OpenFOAM 10: Fixes adapter not reading coupling data#335
simrnjandu wants to merge 1 commit intoprecice:OpenFOAM10from
simrnjandu:OpenFOAM10

Conversation

@simrnjandu
Copy link

Added missing call to readCouplingData(), which ensures that data is read from the precice buffer.

This fixes the issue of perpendicular-flap tutorial showing no displacement of the interface on openfoam's side.

@MakisH
Copy link
Member

MakisH commented Jul 7, 2024

Thank you for contributing!
Important context (it took me a bit to realize): this is targeting the OpenFOAM10 branch and is not an issue on develop/master:

https://github.com/precice/openfoam-adapter/blob/develop/Adapter.C#L698

This is the result of an incomplete rebasing of the related .org branches, which I still need to fix at some point. But this is interesting now: if you apply this fix, does everything else work? What have you tried?

For context, see #328. Please comment there regarding your needs.

@simrnjandu
Copy link
Author

Important context (it took me a bit to realize): this is targeting the OpenFOAM10 branch and is not an issue on develop/master

I forgot to add a link to the forum topic I created regarding this: https://precice.discourse.group/t/openfoam-org-adapter-doesnt-read-celldisplacement/1971

But this is interesting now: if you apply this fix, does everything else work? What have you tried?

After this fix, these tutorials work as expected: perpendicular-flap (fluid-openfoam and solid-dealii) and flow-over-heated-plate (fluid-openfoam and solid-openfoam)
(after necessary modification of the openfoam case files: precice/tutorials@d5911c9 ).

I have not tried the other tutorials, but I believe they would work as well.

For context, see #328. Please comment there regarding your needs.

I am not using any custom solver, so the latest openfoam org version that is supported by precice does the job for me. I need the org version because the ESI one does not have the required rheology models: https://doc.cfd.direct/openfoam/user-guide-v10/transport-rheology
For now, OpenFOAM10 is working perfectly fine for me!

@MakisH MakisH changed the title Fixes adapter not reading coupling data OpenFOAM 10: Fixes adapter not reading coupling data Jul 18, 2024
@precice-bot
Copy link

This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/openfoam-org-adapter-doesnt-read-celldisplacement/1971/4

@jmozmoz jmozmoz mentioned this pull request Sep 26, 2025
2 tasks
@MakisH MakisH added the compatibility Affecting only specific OpenFOAM / preCICE versions label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility Affecting only specific OpenFOAM / preCICE versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants