Update some JS video examples to use local cache#6523
Open
Update some JS video examples to use local cache#6523
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dgirardi
commented
Apr 9, 2026
| var pbjs = pbjs || {}; | ||
| pbjs.que = pbjs.que || []; | ||
| <script type="text/javascript" class="cmplazyload" data-cmp-purpose="c51"> | ||
| loadScript('https://cdnjs.cloudflare.com/ajax/libs/video.js/6.4.0/video.js') |
Contributor
Author
There was a problem hiding this comment.
Note that I found it necessary to "manually" load scripts here because the "cmplazyload" was messing with the load order and I couldn't figure out if there's a way to set it through CMP configuration / attributes.
I tried to add the same note as a jinja comment ({# #}) but it just gets included in the output verbatim - and I'm not even sure this is using jinja.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏷 Type of documentation
This updates some instream videos examples to work and use the local cache.