Skip to content

Anonymised RTD: removed tagUrl setting#14675

Open
kyrylenko wants to merge 5 commits intoprebid:masterfrom
id-ward:anonymisedRtdProvider-ANON-8039-remove-tagUrl-config-setting
Open

Anonymised RTD: removed tagUrl setting#14675
kyrylenko wants to merge 5 commits intoprebid:masterfrom
id-ward:anonymisedRtdProvider-ANON-8039-remove-tagUrl-config-setting

Conversation

@kyrylenko
Copy link
Copy Markdown
Contributor

Type of change

  • Other

Description of change

The obsolete params.tagUrl config option has been removed. The Anonymised Marketing Tag is now always loaded from the hardcoded URL (https://static.anonymised.io/light/loader.js), preventing publishers from overriding it with an arbitrary external script.

Other information

Documentation PR prebid/prebid.github.io#6515

Copilot AI review requested due to automatic review settings April 2, 2026 12:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the obsolete params.tagUrl configuration from the Anonymised RTD provider so the Marketing Tag is always loaded from the fixed static.anonymised.io URL, preventing publisher overrides.

Changes:

  • Hardcode the Marketing Tag loader URL (ignoring params.tagUrl).
  • Update unit tests to reflect the default URL behavior and add DOM cleanup between tests.
  • Update module documentation to remove the params.tagUrl option.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
modules/anonymisedRtdProvider.js Removes tagUrl override and always loads the Marketing Tag from the default URL.
test/spec/modules/anonymisedRtdProvider_spec.js Updates expectations for default URL loading and removes the obsolete tagUrl-based test path.
modules/anonymisedRtdProvider.md Removes params.tagUrl from the documented configuration options.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ctor selector, so it matches http://, https://, and protocol-relative (//) src values.
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 2, 2026

Pull Request Test Coverage Report for Build 23941713782

Details

  • 28 of 28 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 96.341%

Files with Coverage Reduction New Missed Lines %
test/spec/modules/id5AnalyticsAdapter_spec.js 1 96.13%
Totals Coverage Status
Change from base Build 23926477506: 0.0%
Covered Lines: 216809
Relevant Lines: 225043

💛 - Coveralls

@patmmccann
Copy link
Copy Markdown
Collaborator

patmmccann commented Apr 2, 2026

This seems like a breaking change. Publishers currently can copy paste your script to their own cdn and test new versions for behavior and performance; this regression removes that ability

We are inclined to decline this removal of useful functionality

@patmmccann patmmccann changed the title removed obsolete tagUrl setting Anonymised RTD: removed tagUrl setting Apr 2, 2026
@patmmccann patmmccann self-assigned this Apr 2, 2026
@patmmccann patmmccann requested review from patmmccann and removed request for robertrmartinez April 2, 2026 14:50
@kyrylenko
Copy link
Copy Markdown
Contributor Author

This seems like a breaking change. Publishers currently can copy paste your script to their own cdn and test new versions for behavior and performance; this regression removes that ability

We are inclined to decline this removal of useful functionality

Hi @patmmccann
https://static.anonymised.io/light/loader.js is the only URL from which the Anonymised tag can be served. This is because it is not a CDN asset, but an API endpoint that dynamically injects configuration based on the publisher’s domain. If a publisher copy paste the script to their own CDN, it will not work

For this reason, we have decided to deprecate the possibility for publishers to use a custom URL, so we have removed the params.tagUrl parameter

@patmmccann
Copy link
Copy Markdown
Collaborator

patmmccann commented Apr 2, 2026

We ship breaking changes in major versions, we just shipped prebid 11 so this may be a while; you can undocument it now and ship a warning, what we don't want to happen is people refuse to upgrade a minor prebid version bc they want to avoid your change

@kyrylenko
Copy link
Copy Markdown
Contributor Author

Hi @patmmccann , thanks for the guidance, here is what I've updated:
anonymisedRtdProvider.js: params.tagUrl is retained but now logs a deprecation warning when set. The required query string parameters ?ref=prebid&d=<hostname> are always appended to the tag URL, including when a custom tagUrl is provided
anonymisedRtdProvider.md: params.tagUrl is marked as Deprecated in the config table.

@jon-caines-idward
Copy link
Copy Markdown

Good morning @patmmccann. Could you please provide feedback on Pavlo's latest comment? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants