Anonymised RTD: removed tagUrl setting#14675
Anonymised RTD: removed tagUrl setting#14675kyrylenko wants to merge 5 commits intoprebid:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the obsolete params.tagUrl configuration from the Anonymised RTD provider so the Marketing Tag is always loaded from the fixed static.anonymised.io URL, preventing publisher overrides.
Changes:
- Hardcode the Marketing Tag loader URL (ignoring
params.tagUrl). - Update unit tests to reflect the default URL behavior and add DOM cleanup between tests.
- Update module documentation to remove the
params.tagUrloption.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
modules/anonymisedRtdProvider.js |
Removes tagUrl override and always loads the Marketing Tag from the default URL. |
test/spec/modules/anonymisedRtdProvider_spec.js |
Updates expectations for default URL loading and removes the obsolete tagUrl-based test path. |
modules/anonymisedRtdProvider.md |
Removes params.tagUrl from the documented configuration options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ctor selector, so it matches http://, https://, and protocol-relative (//) src values.
Pull Request Test Coverage Report for Build 23941713782Details
💛 - Coveralls |
…Url-config-setting
|
This seems like a breaking change. Publishers currently can copy paste your script to their own cdn and test new versions for behavior and performance; this regression removes that ability We are inclined to decline this removal of useful functionality |
Hi @patmmccann For this reason, we have decided to deprecate the possibility for publishers to use a custom URL, so we have removed the |
|
We ship breaking changes in major versions, we just shipped prebid 11 so this may be a while; you can undocument it now and ship a warning, what we don't want to happen is people refuse to upgrade a minor prebid version bc they want to avoid your change |
|
Hi @patmmccann , thanks for the guidance, here is what I've updated: |
|
Good morning @patmmccann. Could you please provide feedback on Pavlo's latest comment? Thanks |
Type of change
Description of change
The obsolete
params.tagUrlconfig option has been removed. The Anonymised Marketing Tag is now always loaded from the hardcoded URL (https://static.anonymised.io/light/loader.js), preventing publishers from overriding it with an arbitrary external script.Other information
Documentation PR prebid/prebid.github.io#6515