Skip to content

LOGLY Bidder Adapter: add new bidder adapter#14673

Merged
patmmccann merged 2 commits intoprebid:masterfrom
logly:add_logly_bid_adapter
Apr 2, 2026
Merged

LOGLY Bidder Adapter: add new bidder adapter#14673
patmmccann merged 2 commits intoprebid:masterfrom
logly:add_logly_bid_adapter

Conversation

@shiba44
Copy link
Copy Markdown
Contributor

@shiba44 shiba44 commented Apr 2, 2026

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Updated bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add new LOGLY bidder adapter.

  • contact email of the adapter’s maintainer: dev@logly.co.jp
  • test parameters for validating bids:
{
    bidder: 'logly',
    params: {
      adspotId: 4338071
    }
}

Other information

@shiba44 shiba44 marked this pull request as ready for review April 2, 2026 05:24
Copilot AI review requested due to automatic review settings April 2, 2026 05:24
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: affcab0048

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new LOGLY bidder adapter to Prebid.js, including unit tests and module documentation, enabling banner demand to be requested from LOGLY’s endpoint.

Changes:

  • Introduce logly bidder adapter implementation (banner-only) with request-building and response interpretation logic.
  • Add unit tests covering request validation, request payload construction (including im_uid extraction), and response interpretation.
  • Add module documentation with maintainer info and test parameters.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
modules/loglyBidAdapter.ts New LOGLY bidder adapter implementation (request/response logic, optional im_uid support).
test/spec/modules/loglyBidAdapter_spec.js New spec tests validating adapter behavior and payload fields.
modules/loglyBidAdapter.md New adapter documentation and test parameters snippet.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@review-assignment-bot review-assignment-bot bot requested a review from osazos April 2, 2026 17:44
@coveralls
Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 23886176401

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 89 of 89 (100.0%) changed or added relevant lines in 2 files are covered.
  • 20 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.003%) to 96.34%

Files with Coverage Reduction New Missed Lines %
src/utils.js 1 92.17%
modules/userId/index.ts 19 95.26%
Totals Coverage Status
Change from base Build 23870019534: 0.003%
Covered Lines: 216826
Relevant Lines: 225064

💛 - Coveralls

@patmmccann patmmccann merged commit 3272874 into prebid:master Apr 2, 2026
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants