Permutive RTD: support msft bidder custom cohorts#14655
Open
AntonioGargaro wants to merge 5 commits intoprebid:masterfrom
Open
Permutive RTD: support msft bidder custom cohorts#14655AntonioGargaro wants to merge 5 commits intoprebid:masterfrom
AntonioGargaro wants to merge 5 commits intoprebid:masterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82bdf2ea4b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
AntonioGargaro
force-pushed
the
agent/permutive-msft-bidder-support
branch
2 times, most recently
from
61e9fd4 to
2dd62c8
Compare
…orage read Add a `bidders` config to the Permutive RTD module that allows configuring per-bidder custom cohort storage sources. This enables the msft bidder (Microsoft/Xandr) to read custom cohorts from the same localStorage key (`_papns`) used by appnexus, resolving an issue where publishers migrating from appnexus to msft lost custom cohort targeting. Refactors `updateOrtbConfig` to receive resolved `customCohortsData` directly instead of performing the lookup internally, keeping segment resolution centralized in `setBidderRtb`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AntonioGargaro
force-pushed
the
agent/permutive-msft-bidder-support
branch
from
2dd62c8 to
399c45c
Compare
Collaborator
Coverage Report for CI Build 24198265083Coverage increased (+0.001%) to 96.344%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
Author
|
Hey @gwhigs @patmmccann, I wonder if I can bump this for a review 🙏 Appreciate you're both busy, so thank you |
gwhigs
requested changes
Apr 9, 2026
Collaborator
gwhigs
left a comment
gwhigs
left a comment
There was a problem hiding this comment.
I think we need to update docs as well:
- modules/permutiveRtdProvider.md
- https://github.com/prebid/prebid.github.io/blob/master/dev-docs/modules/permutiveRtdProvider.md
Add msft to supported custom cohort bidders list, document the new params.bidders configuration, and note the appnexus-to-msft migration path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
Contributor
Author
|
@patmmccann @gwhigs Docs PR created: prebid/prebid.github.io#6522 Also, if you get a chance, could you review this one too? prebid/prebid.github.io#6352 |
gwhigs
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
biddersparam to the Permutive RTD module that allows per-bidder custom cohort storage sourcesmsftbidder (Microsoft/Xandr) to read custom cohorts from the same localStorage key (_papns) used byappnexusupdateOrtbConfigto receive resolvedcustomCohortsDatadirectly, centralizing segment resolution insetBidderRtbBackground
Publishers migrating from the
appnexusbidder tomsft(per Microsoft's instructions) lost custom cohort targeting (permutive=keywords) becausesegmentData.msftdoesn't exist — custom cohorts from_papnsare stored undersegmentData.appnexus. Standard AC cohorts (p_standard=) continued to work. This change introduces abiddersconfig with acustomCohortsFromfield that specifies the localStorage key to read from, defaultingmsftto_papns.Test plan
gulp lintpassesgulp test --nolint --file test/spec/modules/permutiveCombined_spec.js— all 47 tests pass🤖 Generated with Claude Code