Add Rediads user ID submodule and docs examples#14640
Add Rediads user ID submodule and docs examples#14640symplorpro wants to merge 3 commits intoprebid:masterfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f398162e3d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
|
Pull Request Test Coverage Report for Build 24017714090Details
💛 - Coveralls |
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
|
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
|
|
@osazos @jsnellbaker can you please help us for code review and approval. |
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
This PR adds a new Prebid User ID submodule:
rediadsIdSystem.The new module:
rediadsIduserIdframeworkbidRequest.userId.rediadsIdbidRequest.userIdAsEidswith sourcerediads.comundefinedwhen COPPA applies or when GDPR applies without a valid consent string and Purpose 1 consentThis PR also includes:
modules/.submodules.jsondecode(),getId(),extendId(), and EID generationmodules/rediadsIdSystem.mdmodules/userId/userId.mdmodules/userId/eids.mdFiles changed:
modules/rediadsIdSystem.jstest/spec/modules/rediadsIdSystem_spec.jsmodules/.submodules.jsonmodules/rediadsIdSystem.mdmodules/userId/userId.mdmodules/userId/eids.mdBuild example:
Example configuration:
Other information
Companion docs PR: prebid/prebid.github.io#6503