Skip to content

fix: hide drop label when at max capacity (#819) #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
People-Sea wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: hide drop label when at max capacity (#819) #1067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions dist/filepond.esm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8150,26 +8150,27 @@ const write$9 = ({ root, props, actions }) => {
// action used to add item
const addAction = actions.find(action => action.type === 'DID_ADD_ITEM');

// if reached max capacity and we've just reached it
if (atMaxCapacity && addAction) {
// get interaction type
const interactionMethod = addAction.data.interactionMethod;

// hide label
// hide label when at max capacity
if (atMaxCapacity) {
label.opacity = 0;

if (isMultiItem) {
label.translateY = -40;
} else {
if (interactionMethod === InteractionMethod.API) {
label.translateX = 40;
} else if (interactionMethod === InteractionMethod.BROWSE) {
label.translateY = 40;
// only animate translation when item is being added
if (addAction) {
const interactionMethod = addAction.data.interactionMethod;

if (isMultiItem) {
label.translateY = -40;
} else {
label.translateY = 30;
if (interactionMethod === InteractionMethod.API) {
label.translateX = 40;
} else if (interactionMethod === InteractionMethod.BROWSE) {
label.translateY = 40;
} else {
label.translateY = 30;
}
}
}
} else if (!atMaxCapacity) {
} else {
label.opacity = 1;
label.translateX = 0;
label.translateY = 0;
Expand Down
2 changes: 1 addition & 1 deletion dist/filepond.esm.min.js
View file
Open in desktop

Large diffs are not rendered by default.

31 changes: 16 additions & 15 deletions dist/filepond.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10976,26 +10976,27 @@
return action.type === 'DID_ADD_ITEM';
});

// if reached max capacity and we've just reached it
if (atMaxCapacity && addAction) {
// get interaction type
var interactionMethod = addAction.data.interactionMethod;

// hide label
// hide label when at max capacity
if (atMaxCapacity) {
label.opacity = 0;

if (isMultiItem) {
label.translateY = -40;
} else {
if (interactionMethod === InteractionMethod.API) {
label.translateX = 40;
} else if (interactionMethod === InteractionMethod.BROWSE) {
label.translateY = 40;
// only animate translation when item is being added
if (addAction) {
var interactionMethod = addAction.data.interactionMethod;

if (isMultiItem) {
label.translateY = -40;
} else {
label.translateY = 30;
if (interactionMethod === InteractionMethod.API) {
label.translateX = 40;
} else if (interactionMethod === InteractionMethod.BROWSE) {
label.translateY = 40;
} else {
label.translateY = 30;
}
}
}
} else if (!atMaxCapacity) {
} else {
label.opacity = 1;
label.translateX = 0;
label.translateY = 0;
Expand Down
2 changes: 1 addition & 1 deletion dist/filepond.min.js
View file
Open in desktop

Large diffs are not rendered by default.

31 changes: 16 additions & 15 deletions src/js/app/view/root.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,26 +163,27 @@ const write = ({ root, props, actions }) => {
// action used to add item
const addAction = actions.find(action => action.type === 'DID_ADD_ITEM');

// if reached max capacity and we've just reached it
if (atMaxCapacity && addAction) {
// get interaction type
const interactionMethod = addAction.data.interactionMethod;

// hide label
// hide label when at max capacity
if (atMaxCapacity) {
label.opacity = 0;

if (isMultiItem) {
label.translateY = -40;
} else {
if (interactionMethod === InteractionMethod.API) {
label.translateX = 40;
} else if (interactionMethod === InteractionMethod.BROWSE) {
label.translateY = 40;
// only animate translation when item is being added
if (addAction) {
const interactionMethod = addAction.data.interactionMethod;

if (isMultiItem) {
label.translateY = -40;
} else {
label.translateY = 30;
if (interactionMethod === InteractionMethod.API) {
label.translateX = 40;
} else if (interactionMethod === InteractionMethod.BROWSE) {
label.translateY = 40;
} else {
label.translateY = 30;
}
}
}
} else if (!atMaxCapacity) {
} else {
label.opacity = 1;
label.translateX = 0;
label.translateY = 0;
Expand Down