Improve Lazer Combo Based Miss Estimation #37192
Open
piiidosu wants to merge 3 commits intoppy:pp-devfrom
Open
Improve Lazer Combo Based Miss Estimation #37192piiidosu wants to merge 3 commits intoppy:pp-devfrom
piiidosu wants to merge 3 commits intoppy:pp-devfrom
Conversation
… combo based miss estimation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing and dropping slider ticks also "reduces" combo (as you no longer receive the 1 combo for hitting them as well as breaking combo), and thus should be removed from the maximum achievable combo when determining (roughly) how many misses in a play when the combo does not match the highest achievable combo based on dropped slider ends. This works in Lazer due to sliders' subobjects having individual judgements stored in score data.
This change produces almost negligible deltas but should be a slight improvement.