Display beatmap state in RankedPlayUserDisplay#37188
Open
LiquidPL wants to merge 2 commits intoppy:masterfrom
Open
Display beatmap state in RankedPlayUserDisplay#37188LiquidPL wants to merge 2 commits intoppy:masterfrom
RankedPlayUserDisplay#37188LiquidPL wants to merge 2 commits intoppy:masterfrom
Conversation
This has gone through a few iterations, and eventually ended up as a simple text percentage display next to the username. I feel that adding another progress bar right next to the big healthbar would make things too cluttered. I considered making the local user fetch download progress data using `BeatmapDownloadTracker` instead of relying on `BeatmapAvailability` in order to get more frequent updates, but that would add a lot of extra complexity for little gain IMO.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
|
Feels very hidden, but better than nothing i guess. |
Contributor
Author
What about something like this? It's lifted directly from the multiplayer room participants list so it would need some adjusting. Could probably make the progress bar a little smaller at least. |
peppy
reviewed
Apr 3, 2026
Comment on lines
+177
to
+182
| beatmapState.FadeIn(50); | ||
|
|
||
| switch (availability.State) | ||
| { | ||
| default: | ||
| beatmapState.FadeOut(50); |
Member
There was a problem hiding this comment.
Feels weird to fade in just to fade out.
|
|
||
| case DownloadState.Downloading: | ||
| double progress = Math.Clamp(availability.DownloadProgress ?? 0, 0, 1); | ||
| beatmapState.Text = $"Downloading ({progress:P0})"; |
Member
There was a problem hiding this comment.
probably ellipsis ongoing operations downloading/importing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has gone through a few iterations, and eventually ended up as a simple text percentage display next to the username. I feel that adding another progress bar right next to the big healthbar would make things too cluttered, and trying to move the beatmap state elsewhere would make it too disconnected from the players that are potentially downloading a beatmap.
I considered making the local user fetch download progress data using
BeatmapDownloadTrackerinstead of relying onBeatmapAvailabilityin order to get more frequent updates, but that would add a lot of extra complexity for little gain IMO.Screencast_20260403_095644.webm