osu!taiko reading difficulty rework#37168
Open
buyaspacecube wants to merge 6 commits intoppy:pp-devfrom
Open
Conversation
stanriders
requested changes
Apr 1, 2026
| /// The combined star rating of all skills. | ||
| /// </summary> | ||
| [JsonProperty("star_rating_classic", Order = -2)] | ||
| public double StarRatingClassic { get; set; } |
Member
There was a problem hiding this comment.
This can't exist. You will have to wait for the realtime diffcalc for different classic/non-classic SR. For now assume everything is calculated with CL
Member
Author
There was a problem hiding this comment.
would this deploy be a good time to get realtime merged?
Member
There was a problem hiding this comment.
This is not up to us and as far as I know not coming in the roadmap any time soon. Please just take any changes that rely on realtime's existence out and we'll revisit when we can
Member
Author
There was a problem hiding this comment.
unfortunate, i'll see what i can do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves all mod bonuses to difficulty out of performance and into reading, as well as adjusting their effects on difficulty based on feedback. Currently being balanced with my rhythm change planned for this deploy at https://pp.huismetbenen.nl/rankings/players/otona-plus-reading, and any balancing changes will be made in a separate PR afterwards
Notably, bonuses/nerfs from the classic mod are moved into diffcalc. Without ppy/osu-queue-score-statistics#274 this is implemented by calculating difficulty both with and without the classic mod, and picking the correct star rating and consistency factor to use in performance. This can be hugely simplified as soon as realtime is merged but for now I think this is the best we can do. I will leave databasing to the maintainers as I'm not 100% sure how to go about it. This also comes with the challenge of displaying the right star rating in each client which I'm also not sure where to start