Add LimitReduction with a value above 1#3856
Open
NathanDissoubray wants to merge 5 commits intomainfrom
Open
Conversation
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
olperr1
requested changes
Apr 10, 2026
Co-authored-by: Olivier Perrin <olivier.perrin@rte-france.com> Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Closes #3706
What kind of change does this PR introduce?
Add ability to use a limit reduction with a value above 1.
What is the current behavior?
Currently, a limit reduction is with a value between 0 and 1.
What is the new behavior (if this is a feature change)?
The value can now be above 1.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information:
This will need a renaming PR, as reduction is not really suited when the value can increase the limit instead. This PR only introduces the functionnality changes, the renaming is left in another PR in order to make this PR smaller and more manageable.
The RTD has not been modified as no functionnality change needs to be reported in the doc. The changes are purely naming related, and will thus be done with the renaming PR