Add private extensions validation (loadflow-validation)#3820
Open
samirromdhani wants to merge 3 commits intomainfrom
Open
Add private extensions validation (loadflow-validation)#3820samirromdhani wants to merge 3 commits intomainfrom
samirromdhani wants to merge 3 commits intomainfrom
Conversation
samirromdhani
force-pushed
the
feat/696_loadflow_validation_extension
branch
6 times, most recently
from
c2285cc to
327b46d
Compare
olperr1
reviewed
Mar 16, 2026
Comment on lines
147
to
148
Member
There was a problem hiding this comment.
The problem with the unit test comes from these lines.
Paths.get(...) retrieves the file from the OS file system, but in the unit test we use a virtual FS.
See for instance how it is done in DynamicSimulationTool: the FS that is used is retrieved from the context.
Contributor
Author
There was a problem hiding this comment.
Thanks, that’s helpful! I see how using the FS from context's tool.
samirromdhani
force-pushed
the
feat/696_loadflow_validation_extension
branch
11 times, most recently
from
a0c431d to
9c0abce
Compare
samirromdhani
force-pushed
the
feat/696_loadflow_validation_extension
branch
from
f9eaad5 to
c53de78
Compare
samirromdhani
changed the title
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com> add ExtensionsValidation tests Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com> WIP Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com> add doc Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com> test Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com> fix fix test Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com> test Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
Signed-off-by: Samir Romdhani <samir.romdhani_externe@rte-france.com>
samirromdhani
force-pushed
the
feat/696_loadflow_validation_extension
branch
from
c53de78 to
3a738cb
Compare
|
rolnico
requested changes
Apr 17, 2026
Member
rolnico
left a comment
rolnico
left a comment
There was a problem hiding this comment.
Seems good except for a fix needed in the documentation.
To be sure that everything works fine, it could be tested with an OLF extension for example?
Comment on lines
+90
to
+92
| `--with-extensions-validation`<br> | ||
| Use the `--with-extensions-validation` parameter to perform extensions validation. | ||
|
|
Member
There was a problem hiding this comment.
Wrong place, you put it between an argument and the examples linked to that argument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #696
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: