Skip to content

Add Loader After Login#405

Closed
Subhas6033 wants to merge 1 commit intopooranjoyb:masterfrom
Subhas6033:Subhas6033/feat/loader
Closed

Add Loader After Login#405
Subhas6033 wants to merge 1 commit intopooranjoyb:masterfrom
Subhas6033:Subhas6033/feat/loader

Conversation

@Subhas6033
Copy link
Copy Markdown

This PR implements a loading indicator that appears after a user successfully logs in. The loader will display until the necessary data is fetched or the next page loads, improving user experience by indicating that the app is processing the login request.

Fixes #404

Type of change

Add a piece of JSX in the bottom at Home page

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor Code
  • A documentation update
  • Others(mentioned in the issue number)

How Has This Been Tested?

Run in my local machine

Screenshots and Videos:

PopShop and 4 more pages - Subhas - Microsoft​ Edge 04-03-2025 23_18_44

Checklist:

Give a X on, which is applicable

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pop-shop ❌ Failed (Inspect) Mar 4, 2025 6:01pm

@Subhas6033
Copy link
Copy Markdown
Author

@pooranjoyb, please review this

Copy link
Copy Markdown
Owner

@pooranjoyb pooranjoyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Subhas6033! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@pooranjoyb
Copy link
Copy Markdown
Owner

Please run npm run build and fix the build errors,

@pooranjoyb
Copy link
Copy Markdown
Owner

Don't change existing code. Please do the needful as mentioned in the issue. @Subhas6033

@Subhas6033 Subhas6033 closed this by deleting the head repository Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a custom loader after logging

2 participants