perf(python): Use PyO3 to convert between Python and Rust datetimes#20660
Merged
ritchie46 merged 1 commit intopola-rs:mainfrom Jan 13, 2025
Merged
perf(python): Use PyO3 to convert between Python and Rust datetimes#20660ritchie46 merged 1 commit intopola-rs:mainfrom
ritchie46 merged 1 commit intopola-rs:mainfrom
Conversation
bschoenmaeckers
force-pushed
the
datetime-convert
branch
from
478c209 to
45d66f0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20660 +/- ##
==========================================
- Coverage 79.03% 79.02% -0.01%
==========================================
Files 1559 1559
Lines 221238 221235 -3
Branches 2529 2529
==========================================
- Hits 174851 174834 -17
- Misses 45806 45819 +13
- Partials 581 582 +1 ☔ View full report in Codecov by Sentry. |
bschoenmaeckers
commented
Jan 10, 2025
| delta.num_microseconds().unwrap() | ||
| }; | ||
|
|
||
| Ok(AnyValue::Datetime(timestamp, TimeUnit::Microseconds, None)) |
Contributor
Author
There was a problem hiding this comment.
Should this return the timezone info instead of None in the cases where there is one?
Member
There was a problem hiding this comment.
Currently we don't. I think eventually we have to, but then we also need to infer which timezone to set on the dtype.
alexander-beedie
changed the title
github-actions
Bot
added
performance
bschoenmaeckers
force-pushed
the
datetime-convert
branch
2 times, most recently
from
7d9b9e6 to
54507d2
Compare
bschoenmaeckers
requested review from
MarcoGorelli,
alexander-beedie,
c-peters,
reswqa and
ritchie46
as code owners
CodSpeed Performance ReportMerging #20660 will not alter performanceComparing Summary
|
bschoenmaeckers
force-pushed
the
datetime-convert
branch
from
54507d2 to
0a3fa09
Compare
ritchie46
approved these changes
Jan 13, 2025
Member
|
Thank you @bschoenmaeckers! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #16199
Waiting for pyo3 v0.23.4 to be released. PyO3/pyo3#4835